Milestone v131 — Migrating to WorkManager, OSM prompt option, file upload broadcast, notification for errors, SPD_KPH param #1126
+1,503
−1,559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mendhak
commented
Mar 16, 2024
mendhak
commented
Mar 16, 2024
mendhak
commented
Mar 16, 2024
gpslogger/src/main/java/com/mendhak/gpslogger/common/Systems.java
Outdated
Show resolved
Hide resolved
mendhak
commented
Mar 16, 2024
mendhak
changed the title
Modify speed value so that a conversion to km/h results in an integer value
… service to only after the permission check is complete. In the stop service, only stop the service if notifications are enabled, due to a weird scenario where the service might start and immediately end due to lack of notifications, resulting in an app crash. How did we end up like this. Issue #1138 Issue #1053
mendhak
force-pushed
the
android_workmanager
branch
from
2cc5d97
to
95fa61a
Compare
mendhak
changed the title
…tion." This reverts commit f0d886a.
…om unexpected stop, check permissions before restarting logging
Updating v131 with latest changes from master branch
|
Merged, now I wait a bit so weblate gets the latest in case some translations make it in time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test APK
https://github.com/mendhak/gpslogger/releases/tag/v131-rc2
Housekeeping and Maintenance
The JobQueue library is quite good, but the library is abandoned, and the same developer has done some work on Android WorkManager.
Switching to WorkManager.
One limitation, you can't pass information in the constructor to the worker (like you did with the JobQueue), instead it has to be passed via a Data, and maximum data size is 10kb.
That size limit means instead of passing an array of locations, I have to pass the file name and get the worker to read from the file and build the locations itself.
I've also updated the build dependencies, some libraries too, seen in build.gradle and AndroidManifest.xml.
Issues
#1129 Clarifying that the auto send also sends when the file name changes.
#1131 OpenStreetMap option to prompt for details when logging starts.
#1083 Send a broadcast when a file is uploaded. This should allow users to delete the file if they'd like.
#1139 A new
%SPD_KPHcustom URL parameter to help with logging to OwnTracks.#1138 #1053 Show an error notification when permissions have been revoked but the user is trying to run the app.