-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue related to removing last product from the collection #7348
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
Nice @thetutlage – could you add a test too? 🙏 |
Tests added. The PR is ready for review |
Some unrelated tests from the notification module are failing |
packages/modules/product/src/services/product-module-service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/modules/product/src/services/product-module-service.ts
Outdated
Show resolved
Hide resolved
packages/modules/product/src/services/product-module-service.ts
Outdated
Show resolved
Hide resolved
@thetutlage minor thing, could I get you to use squash and merge going forward? 🙏 |
Sure. Will keep that in mind |
We had an early return which was causing not running any Database queries when last product the removed. The fix was simply to remove the check