Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue related to removing last product from the collection #7348

Merged
merged 9 commits into from
May 17, 2024

Conversation

thetutlage
Copy link
Contributor

We had an early return which was causing not running any Database queries when last product the removed. The fix was simply to remove the check

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 10:02am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) May 17, 2024 10:02am
docs-ui ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 10:02am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 10:02am

Copy link

changeset-bot bot commented May 16, 2024

⚠️ No Changeset found

Latest commit: cf15f5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@olivermrbl
Copy link
Contributor

Nice @thetutlage – could you add a test too? 🙏

@thetutlage
Copy link
Contributor Author

Tests added. The PR is ready for review

@thetutlage
Copy link
Contributor Author

Some unrelated tests from the notification module are failing

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thetutlage thetutlage merged commit ff33749 into develop May 17, 2024
17 checks passed
@thetutlage thetutlage deleted the fix/2152 branch May 17, 2024 10:18
@olivermrbl
Copy link
Contributor

@thetutlage minor thing, could I get you to use squash and merge going forward? 🙏

@thetutlage
Copy link
Contributor Author

Sure. Will keep that in mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants