Remove t from miscellaneous components #27058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-cloud-bot
added
the
release-note-none
hmhealey
commented
May 17, 2024
| @@ -316,7 +315,8 @@ export default class SidebarCategory extends React.PureComponent<Props, State> { | |||
|
|
|||
| let displayName = category.display_name; | |||
| if (category.type !== CategoryTypes.CUSTOM) { | |||
| displayName = localizeMessage(`sidebar.types.${category.type}`, category.display_name); | |||
| const message = categoryNames[category.type as keyof typeof categoryNames]; | |||
There was a problem hiding this comment.
I spent a while fighting with this, but I could not get it to stop complaining that categoryNames didn't have an entry for 'custom' even though the above line says that it can't be that value specifically. It also didn't work if I changed the above check to category.type in categoryNames either, so I eventually just gave up and went with the type assertion
M-ZubairAhmed
approved these changes
May 21, 2024
harshilsharma63
approved these changes
May 22, 2024
hmhealey
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is part of my mission to eradicate
tfrom last week. Most of it is pretty straightforward replacement oftwithdefineMessage/defineMessages, and I also occasionally removed some use oflocalizeMessageas well, but I'll comment on anything noteworthy below.Ticket Link
https://mattermost.atlassian.net/browse/MM-58324
Release Note