Remove t from post and post textbox components #27056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-cloud-bot
added
the
release-note-none
hmhealey
commented
May 17, 2024
| link = ( | ||
| <FormattedMessage | ||
| id='post_body.check_for_out_of_channel_mentions.link.private' | ||
| defaultMessage='add them to this private channel' |
There was a problem hiding this comment.
Some of these should be rewritten so that we aren't concatenating strings together because sentence order can be different in other languages, but that's another future task
Comment on lines
+2826
to
+2828
| "app.post.move_thread_command.channel.multiple_messages": "A thread with {numMessages, number} messages has been moved: {link}\n", | ||
| "app.post.move_thread_command.channel.one_message": "A message has been moved: {link}\n", | ||
| "app.post.move_thread_command.direct_or_group.multiple_messages": "A thread with {numMessages, number} messages has been moved to a Direct/Group Message\n", |
There was a problem hiding this comment.
These strings were actually completely invalid because they use the Go style of adding values to the string. I don't think that came up before because this feature is experimental, but FormatJS started complaining about them after I changed these to use defineMessages
harshilsharma63
approved these changes
May 22, 2024
devinbinnie
approved these changes
May 22, 2024
devinbinnie
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is part of my mission to eradicate
tfrom last week. Most of it is pretty straightforward replacement oftwithdefineMessage/defineMessages, and I also occasionally removed some use oflocalizeMessageas well, but I'll comment on anything noteworthy below.Ticket Link
https://mattermost.atlassian.net/browse/MM-58324
Release Note