Remove t from system console code #27054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_schemes_settings
mm-cloud-bot
added
the
release-note-none
hmhealey
commented
May 17, 2024
|
|
||
| copyID: string; | ||
| copyDefault: string; | ||
| title: MessageDescriptor; |
There was a problem hiding this comment.
A lot of these changes are replacing ID/default props with a single prop that takes a message descriptor
| let convertMessage; | ||
| if (toPublic) { | ||
| convertMessage = ( | ||
| <FormattedMarkdownMessage |
There was a problem hiding this comment.
There's still some things here that would be worth fixing such as removing FormattedMarkdownMessage and fixing some weird whitespace in this string that the FormatJS ESLint plugin will complain about, but this diff is difficult enough to read as-is, so I'm not changing it yet
| @@ -66,9 +67,21 @@ const GroupList = ({ | |||
| <AbstractList | |||
| header={<Header/>} | |||
| renderRow={renderRow} | |||
| emptyListText={isModeSync ? messages.emptyListModeSync : messages.emptyList} | |||
There was a problem hiding this comment.
This used to be done in the index file for AbstractList which seemed really odd to me and was confusing TypeScript's ability to check the type of props, so I moved it here to make that easier
larkox
approved these changes
May 20, 2024
...onsole/permission_schemes_settings/edit_post_time_limit_modal/edit_post_time_limit_modal.tsx
Show resolved
Hide resolved
...nels/src/components/admin_console/team_channel_settings/convert_and_remove_confirm_modal.tsx
Outdated
Show resolved
Hide resolved
webapp/channels/src/components/admin_console/team_channel_settings/convert_confirm_modal.tsx
Outdated
Show resolved
Hide resolved
webapp/channels/src/components/admin_console/team_channel_settings/group/group_list.tsx
Show resolved
Hide resolved
BenCookie95
approved these changes
May 27, 2024
hmhealey
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is part of my mission to eradicate
tfrom last week. Most of it is pretty straightforward replacement oftwithdefineMessage/defineMessages, and I also occasionally removed some use oflocalizeMessageas well, but I'll comment on anything noteworthy below.Ticket Link
https://mattermost.atlassian.net/browse/MM-58324
Release Note