[CLD-7742] Make location prop on ExternalLink component required #27052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es that are missing it
mm-cloud-bot
added
the
release-note-none
M-ZubairAhmed
approved these changes
May 21, 2024
larkox
approved these changes
May 22, 2024
nickmisasi
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Marketing has requested that the
utm_contentparameter not be empty - it's driven by thelocationprop on theExternalLinkcomponent. This PR removes the optionality of that prop so that it must be passed. This PR also updates existing occurrences of the ExternalLink that were missing thelocationprop.Ticket Link
https://mattermost.atlassian.net/browse/CLD-7742
Screenshots
Release Note