Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds RemoteId to the fields to clean when coming from the API #27047

Merged
merged 4 commits into from
May 22, 2024

Conversation

mgdelacroix
Copy link
Member

Ticket Link

https://mattermost.atlassian.net/browse/MM-58279

Release Note

NONE

@mgdelacroix mgdelacroix added 2: Dev Review Requires review by a developer 3: Security Review Review requested from Security Team labels May 17, 2024
@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 17, 2024
@wiggin77
Copy link
Member

/update-branch

Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@JulienTant JulienTant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mgdelacroix

@mgdelacroix
Copy link
Member Author

/update-branch

@esarafianou esarafianou removed the 3: Security Review Review requested from Security Team label May 22, 2024
@mgdelacroix mgdelacroix added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels May 22, 2024
@mgdelacroix mgdelacroix merged commit a4afae5 into master May 22, 2024
41 checks passed
@mgdelacroix mgdelacroix deleted the mm-58279-clean-remoteid-in-createuser-endpoint branch May 22, 2024 09:20
@amyblais
Copy link
Member

/cherry-pick release-9.9

@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

@amyblais
Copy link
Member

/cherry-pick release-9.8

@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

@amyblais
Copy link
Member

/cherry-pick release-9.7

mattermost-build pushed a commit that referenced this pull request May 22, 2024
* Cleans the RemoteId when creating a user through the API

* Replace bad usage of the API with an App call in tests

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
(cherry picked from commit a4afae5)
@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

@amyblais
Copy link
Member

/cherry-pick release-9.6

@mattermost-build mattermost-build added the CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone label May 22, 2024
@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

@amyblais
Copy link
Member

/cherry-pick release-9.5

@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit that referenced this pull request May 22, 2024
* Cleans the RemoteId when creating a user through the API

* Replace bad usage of the API with an App call in tests

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
(cherry picked from commit a4afae5)
mattermost-build pushed a commit that referenced this pull request May 22, 2024
* Cleans the RemoteId when creating a user through the API

* Replace bad usage of the API with an App call in tests

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
(cherry picked from commit a4afae5)
mattermost-build pushed a commit that referenced this pull request May 22, 2024
* Cleans the RemoteId when creating a user through the API

* Replace bad usage of the API with an App call in tests

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
(cherry picked from commit a4afae5)
mattermost-build pushed a commit that referenced this pull request May 22, 2024
* Cleans the RemoteId when creating a user through the API

* Replace bad usage of the API with an App call in tests

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
(cherry picked from commit a4afae5)
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants