Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLD-7553 Implement per-MM_ENV runs, post the E2E test links back to user #27042

Merged
merged 2 commits into from
May 21, 2024

Conversation

mvitale1989
Copy link
Member

@mvitale1989 mvitale1989 commented May 17, 2024

Summary

Support running multiple E2E Tests per-PR, one per MM_ENV specification.
Also post back the Workflow and Automation Dashboard URLs as soon as possible in the run.

Tested by running with the following settings:

  • Leaving MM_ENV empty
  • Setting MM_ENV to MM_SUPPORTSETTINGS_HELPLINK=https://about.mattermost.com/default-help/?dummy

Note that in the future, the E2E Tests/test status check (created by runs that leave MM_ENV empty) will be the only one required for PR mergeability.

Ticket Link

https://mattermost.atlassian.net/browse/CLD-7553
https://mattermost.atlassian.net/browse/CLD-7647

Release Note

NONE

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 17, 2024
Copy link

E2E test run is starting for commit a4d9e1ab9ab0bea76a0ccd1a93d2444472a286a5.
You can check its progress by either:

Copy link

E2E test run is starting for commit a4d9e1ab9ab0bea76a0ccd1a93d2444472a286a5, with MM_ENV=MM_SUPPORTSETTINGS_HELPLINK=https://about.mattermost.com/default-help/?dummy.
You can check its progress by either:

Copy link

E2E test run is starting for commit a4d9e1ab9ab0bea76a0ccd1a93d2444472a286a5, with MM_ENV=MM_SUPPORTSETTINGS_HELPLINK=https://about.mattermost.com/default-help/?dummy.
You can check its progress by either:

@mvitale1989
Copy link
Member Author

mvitale1989 commented May 17, 2024

The test was performed as follows (E2E tests were started manually from the Actions tab):

  1. A job with an empty MM_ENV was started, which replied with the first comment
  2. A new job was started with MM_ENV equal to MM_SUPPORTSETTINGS_HELPLINK=https://about.mattermost.com/default-help/?dummy, which replied with the second comment
  3. A third job was started with the same MM_ENV as the second job. This resulted in the second job being automatically canceled because of the concurrency directive.

Concurrency works as expected, so you can run multiple E2E tests with different MM_ENV values in the same PR.

Also note that the last two jobs were canceled before they could generate the test cycle on the automation dashboard.

@mvitale1989 mvitale1989 changed the title Add per-env runs, post feedback back to user CLD-7553 Implement per-MM_ENV runs, post the E2E test links back to user May 17, 2024
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nice! Thanks @mvitale1989!

@saturninoabril saturninoabril added the 4: Reviews Complete All reviewers have approved the pull request label May 21, 2024
@mvitale1989 mvitale1989 merged commit 4a77d9e into master May 21, 2024
59 of 69 checks passed
@mvitale1989 mvitale1989 deleted the cld-7553-add-e2e-cancel-semantics branch May 21, 2024 08:55
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants