-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding unsupported text into the team/e0 edition menu #27038
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this with one really minor change @jespino.
The 'unsupported' link seems to have a background color on hover. Can you adjust so it only has the underline on hover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion otherwise LGTM!
webapp/channels/src/components/widgets/menu/menu_items/menu_start_trial.tsx
Outdated
Show resolved
Hide resolved
E2E test triggered successfully for PR #27038. The corresponding commit's status check will be available shortly. |
@matthewbirtch I made the changes on the styles addressing your proposal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jespino - looks good to me 👍
Please link to the Jira ticket? Thanks!
What does "unsupported" mean in this context? I assume it's supposed to mean that we won't be providing official support to people, but based on the link, that's not obvious to me. That wording really makes it sound like we're not doing releases or maintaining TE going forward |
@hmhealey this text was mulled over with leadership last week and this is where it landed. I understand what you're saying though. I had a similar reaction to the word at first. "Unsupported" here means that commercial support is not included in the free unlicensed versions. The pricing page that we're linking to here will be getting some updated language that includes this 'unsupported' language on the Free version. cc: @chenilim for thoughts |
@jespino @nickmisasi how we verify that the link tracking is working as expected? Just want to be sure we get data coming in properly. |
@matthewbirtch click the link you're looking to validate, and then inspect the query parameters of the URL you're redirected to. For example when I click the link in the spinwick I see: https://mattermost.com/pricing/?utm_source=&utm_medium%20mattermost%20=in-product&utm_content=menu_start_trial.unsupported-link&uid=h9ciej8xk3gq5xps5hh3nn5eyh&sid=nqs437yx6j8idynxsiahbd3pgw |
Thanks @nickmisasi. To clarify, the tracking data we get from this will be in Google Analytics right? Is there some validation we can do there to ensure it's getting tracked correctly (other than seeing the parameters in the query string) |
@matthewbirtch the tracking data will be available to Google Analytics - but whether/how it's consumed by GA is owned by the marketing team. Generally GA captures all query parameters automatically, but to totally validate you'd need to work with them. FWIW, this tracking data is also emitted through rudder at the time of clicking the link. |
@matthewbirtch @jespino can we delete "Start an Enterprise trial"? We don't want admins mistakenly thinking that any end user could start an enterprise trial by having buttons like these outside of the system console. |
Thanks @it33, we will definitely remove this. I should have caught this. @jespino let me know if you have any questions, but here is some extra context to share for those following along:
Happy to have a broader conversation about this and we can chat more in our team meetings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a code perspective, this looks good to me. I still think the wording will scare people more than we should, but that's not my call to make
Cherry pick is scheduled. |
Test server destroyed |
1 similar comment
Test server destroyed |
* Adding unsupported text into the team/e0 edition menu * Fixing CI * Addressing PR review comments * Removing start trial from the product menu * Fixing tests * Updating i18n (cherry picked from commit f4a3a2e)
This kind of trajectory is definitely worrisome. I think non-Mattermost-org folk might need to start considering fork options to ensure we don't see leadership slide this off the rails as so many other similar systems have experienced. The push for more and more free/unsupported labeling/branding is not a good look for an open source system. |
Summary
Changing the text for the free/e0 edition to show in the product menu a text that clarifies that the edition is unsupported.
Ticket Link
Not Yet
Screenshots
Before:
After:
Release Note