Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unsupported text into the team/e0 edition menu #27038

Merged
merged 6 commits into from
May 22, 2024

Conversation

jespino
Copy link
Member

@jespino jespino commented May 17, 2024

Summary

Changing the text for the free/e0 edition to show in the product menu a text that clarifies that the edition is unsupported.

Ticket Link

Not Yet

Screenshots

Before:
imagen

After:
image

Release Note

Added unsupported label to the Team/E0 editions in the product menu.

@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 17, 2024
@amyblais amyblais added this to the v9.9.0 milestone May 17, 2024
@amyblais amyblais added CherryPick/Approved Meant for the quality or patch release tracked in the milestone Docs/Needed Requires documentation 1. UX Review Requires review by a UX Designer labels May 17, 2024
Copy link
Contributor

@matthewbirtch matthewbirtch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this with one really minor change @jespino.

The 'unsupported' link seems to have a background color on hover. Can you adjust so it only has the underline on hover?

image

@matthewbirtch matthewbirtch removed the 1. UX Review Requires review by a UX Designer label May 17, 2024
Copy link
Contributor

@nickmisasi nickmisasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion otherwise LGTM!

@jespino jespino added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review and removed Docs/Needed Requires documentation CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels May 17, 2024
@unified-ci-app
Copy link
Contributor

E2E test triggered successfully for PR #27038. The corresponding commit's status check will be available shortly.

@jespino
Copy link
Member Author

jespino commented May 17, 2024

@matthewbirtch I made the changes on the styles addressing your proposal

@jespino jespino requested a review from hmhealey May 17, 2024 17:31
@jespino jespino added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label May 19, 2024
@amyblais amyblais requested a review from lindy65 May 21, 2024 12:54
@lindy65 lindy65 added the Setup Cloud Test Server Setup an on-prem test server label May 21, 2024
Copy link
Contributor

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jespino - looks good to me 👍

Please link to the Jira ticket? Thanks!

@lindy65 lindy65 added QA/Review Done QA review is completed but other reviews are outstanding (exception to usual process) and removed 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels May 21, 2024
@amyblais amyblais added the Docs/Needed Requires documentation label May 21, 2024
@hmhealey
Copy link
Member

What does "unsupported" mean in this context? I assume it's supposed to mean that we won't be providing official support to people, but based on the link, that's not obvious to me. That wording really makes it sound like we're not doing releases or maintaining TE going forward

@matthewbirtch
Copy link
Contributor

matthewbirtch commented May 21, 2024

What does "unsupported" mean in this context? I assume it's supposed to mean that we won't be providing official support to people, but based on the link, that's not obvious to me. That wording really makes it sound like we're not doing releases or maintaining TE going forward

@hmhealey this text was mulled over with leadership last week and this is where it landed. I understand what you're saying though. I had a similar reaction to the word at first. "Unsupported" here means that commercial support is not included in the free unlicensed versions.

The pricing page that we're linking to here will be getting some updated language that includes this 'unsupported' language on the Free version.

cc: @chenilim for thoughts

@matthewbirtch
Copy link
Contributor

@jespino @nickmisasi how we verify that the link tracking is working as expected? Just want to be sure we get data coming in properly.

@nickmisasi
Copy link
Contributor

@matthewbirtch click the link you're looking to validate, and then inspect the query parameters of the URL you're redirected to. For example when I click the link in the spinwick I see:

https://mattermost.com/pricing/?utm_source=&utm_medium%20mattermost%20=in-product&utm_content=menu_start_trial.unsupported-link&uid=h9ciej8xk3gq5xps5hh3nn5eyh&sid=nqs437yx6j8idynxsiahbd3pgw
the utm parameters and uid/sid are what's added

@matthewbirtch
Copy link
Contributor

@matthewbirtch click the link you're looking to validate, and then inspect the query parameters of the URL you're redirected to.

Thanks @nickmisasi. To clarify, the tracking data we get from this will be in Google Analytics right? Is there some validation we can do there to ensure it's getting tracked correctly (other than seeing the parameters in the query string)

@nickmisasi
Copy link
Contributor

@matthewbirtch the tracking data will be available to Google Analytics - but whether/how it's consumed by GA is owned by the marketing team. Generally GA captures all query parameters automatically, but to totally validate you'd need to work with them.

FWIW, this tracking data is also emitted through rudder at the time of clicking the link.

@it33
Copy link
Contributor

it33 commented May 21, 2024

@matthewbirtch @jespino can we delete "Start an Enterprise trial"?

We don't want admins mistakenly thinking that any end user could start an enterprise trial by having buttons like these outside of the system console.

@matthewbirtch
Copy link
Contributor

Thanks @it33, we will definitely remove this. I should have caught this.

@jespino let me know if you have any questions, but here is some extra context to share for those following along:

  1. A 'start free trial' call-to-action in the chat-facing side of the application is not aligned with our mission-critical brand. It is more akin to methods SaaS products use in SMB markets. It's like the 'upsells' we've used in the past and need to move away from.
  2. The 'unsupported' message is intended to communicate the seriousness of running unsupported software in a mission-critical organization. However, the "Start free trial" language is at odds with that. It downplays the importance of it and cheapens it.
  3. Another concern here is that admins see this 'free trial' button and because it appears on the chat-facing side, they might worry that all end users see the same thing. We don't want to add this stress to our admins.

Happy to have a broader conversation about this and we can chat more in our team meetings.

Copy link
Member

@hmhealey hmhealey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a code perspective, this looks good to me. I still think the wording will scare people more than we should, but that's not my call to make

@hmhealey hmhealey added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels May 22, 2024
@jespino jespino merged commit f4a3a2e into mattermost:master May 22, 2024
16 checks passed
@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

@mattermost-build mattermost-build removed the Setup Cloud Test Server Setup an on-prem test server label May 22, 2024
@mm-cloud-bot
Copy link

Test server destroyed

1 similar comment
@mm-cloud-bot
Copy link

Test server destroyed

mattermost-build pushed a commit that referenced this pull request May 22, 2024
* Adding unsupported text into the team/e0 edition menu

* Fixing CI

* Addressing PR review comments

* Removing start trial from the product menu

* Fixing tests

* Updating i18n

(cherry picked from commit f4a3a2e)
@mattermost-build mattermost-build added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels May 22, 2024
@amyblais amyblais added the Changelog/Done Required changelog entry has been written label May 22, 2024
@ylluminate
Copy link

ylluminate commented May 28, 2024

This kind of trajectory is definitely worrisome. I think non-Mattermost-org folk might need to start considering fork options to ensure we don't see leadership slide this off the rails as so many other similar systems have experienced.

The push for more and more free/unsupported labeling/branding is not a good look for an open source system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Needed Requires documentation QA/Review Done QA review is completed but other reviews are outstanding (exception to usual process) release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants