Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-58304] Move global pluggable outside of new main-wrapper div #27035

Merged
merged 5 commits into from
May 21, 2024
Merged

[MM-58304] Move global pluggable outside of new main-wrapper div #27035

merged 5 commits into from
May 21, 2024

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented May 16, 2024

Summary

  • MM-56975 UI Incremental Refinements #26407 introduced a new main-wrapped div on the root component, and this wrapped the Global pluggable. That changed the dom hierarchy for the global pluggable. I imagine this will affect other plugins as well, which might have relied on being in the previous dom level.
  • For calls:
before after fix
image image

Ticket Link

Release Note

NONE

@cpoile cpoile added 2: Dev Review Requires review by a developer 1. UX Review Requires review by a UX Designer labels May 16, 2024
@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 16, 2024
@cpoile
Copy link
Member Author

cpoile commented May 16, 2024

/update-branch

@amyblais amyblais added this to the v9.9.0 milestone May 16, 2024
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label May 16, 2024
matthewbirtch
matthewbirtch approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@matthewbirtch matthewbirtch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for this @cpoile

@matthewbirtch matthewbirtch removed the 1. UX Review Requires review by a UX Designer label May 17, 2024
streamer45
streamer45 approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cpoile
Copy link
Member Author

cpoile commented May 17, 2024

/update-branch

@devinbinnie devinbinnie added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels May 17, 2024
@cpoile
Copy link
Member Author

cpoile commented May 17, 2024

@hmhealey This is where the performance reporter tests are failing: https://github.com/mattermost/mattermost/actions/runs/9128203751/job/25100070018?pr=27035
Is there something I did in this PR?

@amyblais
Copy link
Member

/update-branch

@amyblais amyblais added the AutoMerge Used by Mattermod to merge PR automatically label May 21, 2024
@mattermost-build
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

@mattermost-build
Copy link
Contributor

Trying to auto merge this PR.

@mattermost-build mattermost-build merged commit 3490143 into master May 21, 2024
24 checks passed
@mattermost-build mattermost-build deleted the MM-58304-fix-global-pluggable branch May 21, 2024 13:41
@mattermost-build
Copy link
Contributor

Pull Request successfully merged
SHA: 3490143

@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

@mattermost-build mattermost-build removed the AutoMerge Used by Mattermod to merge PR automatically label May 21, 2024
mattermost-build pushed a commit that referenced this pull request May 21, 2024
@cpoile @mattermost-build
[MM-58304] Move global pluggable outside of new main-wrapper div (#27035
0828856 
)

Automatic Merge

(cherry picked from commit 3490143)
@mattermost-build mattermost-build mentioned this pull request May 21, 2024
Merged
@mattermost-build mattermost-build added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels May 21, 2024
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 21, 2024
mattermost-build added a commit that referenced this pull request May 21, 2024
@mattermost-build
[MM-58304] Move global pluggable outside of new main-wrapper div (#27035
2cc7c95 
) (#27083)

Automatic Merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamer45 streamer45 streamer45 approved these changes

@matthewbirtch matthewbirtch matthewbirtch approved these changes

@devinbinnie devinbinnie devinbinnie approved these changes

Assignees

@cpoile cpoile

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
v9.9.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cpoile @amyblais @mattermost-build @streamer45 @matthewbirtch @devinbinnie @mm-cloud-bot