Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-58303 Report client metrics to Prometheus in seconds #27033

Merged
merged 2 commits into from
May 21, 2024
Merged

MM-58303 Report client metrics to Prometheus in seconds #27033

merged 2 commits into from
May 21, 2024

Conversation

hmhealey
Copy link
Member

Summary

The default histogram buckets in Prometheus expect values to be measured in seconds, but the web app reports them in milliseconds. I've left the web app reporting metrics in milliseconds since that's how the browser's Performance API wants them, and changed it so that the server translates those into seconds for metrics that need it. There's no conversion for counters or CLS because those aren't times

Ticket Link

https://mattermost.atlassian.net/browse/MM-58303

Release Note

NONE

@hmhealey hmhealey added the 2: Dev Review Requires review by a developer label May 16, 2024
@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 16, 2024
@amyblais amyblais added this to the v9.9.0 milestone May 16, 2024
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label May 16, 2024
@amyblais
Copy link
Member

/update-branch

@hmhealey hmhealey mentioned this pull request May 17, 2024
Merged
isacikgoz
isacikgoz approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@isacikgoz isacikgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyblais amyblais added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels May 21, 2024
@hmhealey hmhealey merged commit b29c211 into master May 21, 2024
41 checks passed
@hmhealey hmhealey deleted the MM-58303_metrics-seconds branch May 21, 2024 17:47
@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit that referenced this pull request May 21, 2024
@hmhealey @mattermost-build
MM-58303 Report client metrics to Prometheus in seconds (#27033)
2093e37 
(cherry picked from commit b29c211)
@mattermost-build mattermost-build mentioned this pull request May 21, 2024
Merged
@mattermost-build mattermost-build added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels May 21, 2024
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 21, 2024
mattermost-build added a commit that referenced this pull request May 21, 2024
@mattermost-build
MM-58303 Report client metrics to Prometheus in seconds (#27033) (#27089
1c9790c 
)

Automatic Merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isacikgoz isacikgoz isacikgoz approved these changes

@crspeller crspeller crspeller approved these changes

Assignees

@hmhealey hmhealey

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
v9.9.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hmhealey @amyblais @mattermost-build @isacikgoz @crspeller @mm-cloud-bot