SystemCheck Addon , check and fix htaccess

[ayurmedia]

Description:

On the Page for SystemCheck Section FileIntegrity this change will show missing .htaccess files, and automatically repair the files like in Update 3.0.0.

As discussed in the Forum, randomly htaccess Files will be missing during Installation.
This Fix will repair the files automatically by removing the managed htaccess files and create them again like during the installation.

https://forum.matomo.org/t/how-to-harden-a-matomo-installation/49765/34?u=unterberger.media

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[sgiehl]

I don't have time right now to read the forum thread, but all htaccess files should be (re)created after setting up the first website during installation and whenever Matomo or a plugin has been updated.
So if such files are missing they might have been removed manually, or the webserver didn't have write permission to the directory.
I personally don't think we should start to do any sort of auto-repair while running file integrity check. It is unexpected that a "check" also performs an action.
Providing a command or an action that can be triggered in the UI would be something more suitable I think.

[github-actions]

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

[michalkleiner]

Following on from sgiehl's comment, would you be able to move the repair mechanism to a task that can be manually triggered? Not sure whether it should be within core, e.g. core:repairhtaccess or similar, but we can start there and then adjust it later on.
I agree with the sentiment that a check shouldn't magically repair the files. It's a check, it can report on the missing files, and suggest running the repair command.

[github-actions]

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

[github-actions]

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers