📺 Add zsh completions #514
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 15, 2024
| '1:name:__mas_list_available' \ | ||
| && ret=0 | ||
| ;; | ||
| open) |
There was a problem hiding this comment.
This pattern never matches because of a previous pattern on line 17.
houndci-bot
reviewed
May 15, 2024
| @@ -0,0 +1,165 @@ | |||
| #! /usr/bin/env zsh | |||
There was a problem hiding this comment.
ShellCheck only supports sh/bash/dash/ksh scripts. Sorry!
|
Let me know if any of these reviews are an actual concern as most aren't applicable. |
houndci-bot
reviewed
May 17, 2024
| } | ||
|
|
||
| __mas_search_names() { | ||
| [[ -z "$words[-1]" ]] && return; |
There was a problem hiding this comment.
Argument to -z is always false due to literal strings.
| } | ||
|
|
||
| __mas_search_ids() { | ||
| [[ -z "$words[-1]" ]] && return; |
There was a problem hiding this comment.
Argument to -z is always false due to literal strings.
Logicer16
force-pushed
the
main
branch
2 times, most recently
from
c6db308
to
63d0fe8
Compare
houndci-bot
reviewed
May 17, 2024
houndci-bot
reviewed
May 17, 2024
|
|
||
| case "$state" in | ||
| args) | ||
| case $words[1] in |
There was a problem hiding this comment.
Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet).
| @@ -0,0 +1,166 @@ | |||
| #compdef mas | |||
| # shellcheck shell=zsh | |||
There was a problem hiding this comment.
This shell type is unknown. Use e.g. sh or bash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#222 has been open for over 5 years now (🥳 congrats). About time someone took care of it, especially as it's the default shell.
Closes #222
Please let me know of any questions/suggestions you might have.