[Typescript] Fix compilation error in MenuItemLink, ResettableTextField and InpectorButton with latest @types/react
#9853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…junk props. According to issue marmelab#9737
fzaninotto
approved these changes
May 17, 2024
fzaninotto
changed the title
MenuItemLink, ResettableTextField and InpectorButton with latest @types/react
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9737
Problem
@types/react v18.2.66 update makes some of our components require extra props.
MenuItemLink- requiresonPointerEnterCapture,onPointerLeaveCaptureResettableTextField- requiresonPointerEnterCapture,onPointerLeaveCaptureInspectorButton- requiresonPointerEnterCapture,onPointerLeaveCaptureandplaceholderProbably InspectorButton.placeholder issue was introduced even before v18.2.66
This breaks new apps bootstrapped from
create-react-admin- you'll get typescript error if using these componentsSolution
Explicitly omit these otherwise junk props and allow to use the components without compilation error