Fix race condition between http error notification and server-side validation error notification #9848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to customize global msg
slax57
changed the title
Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
djhi
approved these changes
May 17, 2024
erwanMarmelab
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When validating server side, you can’t provide a global error message and react-admin displays a default non customizable one.
In some cases (depending on the React version) users could use the error's
messagefield to render a custom message in the notification, but due to a race condition between the 2 notifications, it would not always work.Solution
In
useCreateControlleranduseEditController, check if there are validation errors and if we are in pessimistic mode, and don't notify in this case (as it will be done byuseNotifyIsFormInvalid).In
useNotifyIsFormInvalidnotify with theroot.serverErrormessage if available (otherwise fall back to 'ra.message.invalid_form' like currently).