-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display read-only state of open files using a lock icon #3924
Conversation
e05d7a3
to
ccbaba6
Compare
This should be mostly helpful for people using a VCS like Perforce or Subversion, which may require a file to be checked out or locked before it can be edited. For now the read-only icon is a lock, which is common, but it may be confusing for Subversion users since they actually need to lock the file to make it writable.
ccbaba6
to
c82539e
Compare
Thanks for catching that! It actually happens because internally read-only is set to I agree the unsaved map could be better identified, though the use of "untitled" as file name for unsaved files seems to still be quite ubiquitous. What about just "New Map"? |
"Untitled" as a file name is ubiquitous, yes, but there's no file, and therefore no file name xP "New Map" would work. Even "Untitled" might be fine, the main thing is to get rid of the file extension that implies there's a file. |
Noticed another issue with this: Save As does not update the lock status, only Save does. If you open a read-only file and then Save As to a new file (which will not be read-only), the tab keeps the lock icon. |
Also fixed that when saving a file with a different name, the read-only flag was not refreshed. Fixes for c82539e (see mapeditor#3924).
I don't think Save does (but if the filename stays the same, it would just update based on the file watcher). I've addressed the issue with Save As as well now in a55feec, thanks! |
This should be mostly helpful for people using a VCS like Perforce or Subversion, which may require a file to be checked out or locked before it can be edited.
For now the read-only icon is a lock, which is common, but it may be confusing for Subversion users since they actually need to lock the file to make it writable.