Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] 增加群待办相关事件 #2723

Open
wants to merge 20 commits into
base: dev
Choose a base branch
from
Open

[core] 增加群待办相关事件 #2723

wants to merge 20 commits into from

Conversation

cssxsh
Copy link
Contributor

@cssxsh cssxsh commented Jul 5, 2023

No description provided.

@cssxsh
Copy link
Contributor Author

cssxsh commented Jul 13, 2023

@Him188
要不换个名字

CompleteTodoEvent

@Him188
Copy link
Member

Him188 commented Jul 15, 2023

可以

@Him188 Him188 added t:feature 类型: 新特性 s:core 子系统: mirai-core labels Jul 29, 2023
@Him188 Him188 changed the title New tip event [core] 增加群待办相关事件 Jul 29, 2023
@cssxsh cssxsh requested a review from Him188 August 5, 2023 09:36
Him188
Him188 reviewed Aug 12, 2023
View reviewed changes
Copy link
Member

@Him188 Him188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API 没问题

mirai-core-api/src/commonMain/kotlin/contact/todo/GroupTodo.kt
/**
* @see MemberRecallTodoEvent
*/
public suspend fun recall(source: MessageSource)
Copy link
Member

@Him188 Him188 Aug 12, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改名叫 remove?

mirai-core/src/commonMain/kotlin/contact/todo/GroupTodoImpl.kt Outdated Show resolved Hide resolved
mirai-core/src/commonMain/kotlin/contact/todo/GroupTodoImpl.kt Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Him188 Him188 Him188 approved these changes

@Karlatemp Karlatemp Karlatemp left review comments

Assignees
No one assigned
Labels
s:core 子系统: mirai-core t:feature 类型: 新特性
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cssxsh @Him188 @Karlatemp