Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update en.json: "setup" -> "set up" #4436

Merged
merged 1 commit into from
May 23, 2024

Conversation

bertday
Copy link
Contributor

@bertday bertday commented Jan 30, 2024

Tiny grammar fix: "set up" should be two words when used as a verb.

Thank you for this awesome project!

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes a minor grammar issue (described above).

Type of change

Please delete any options that are not relevant.

  • User interface (UI)

Checklist

This is just an edit to the en.json dictionary — no code changes!

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

Grammar fix: "set up" should be two words when used as a verb
@louislam
Copy link
Owner

louislam commented Feb 3, 2024

Since it is conflict with #4394, it will be merged after #4394 to avoid the Weblate issue.

@louislam louislam added this to the 2.0.0 milestone Feb 3, 2024
@CommanderStorm CommanderStorm changed the title Update en.json Update en.json: "setup" -> "set up" Mar 8, 2024
@CommanderStorm CommanderStorm added the needs:other-pr-merged pending other PR to be merged first label May 19, 2024
@CommanderStorm
Copy link
Collaborator

Merging as we had to merge #4394 due to #4788

@CommanderStorm CommanderStorm merged commit 4df71af into louislam:master May 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
house keeping needs:other-pr-merged pending other PR to be merged first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants