Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): prevent reset after complete by call stop() manually #1231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mym0404
Copy link

@mym0404 mym0404 commented May 17, 2024

In #1196, the stop method of inner player was called for preventing reset after animation completion.

This seems to is not required and also occur reset frame to 0.

this (_handleAnimationComplete handler of @dotlottie/react-player) shows the frame should be in last frame at complete automatically if loop not set and doesn't call stop() unless loop condition true.

Also, stop method implementation of lottie-web resets frame to zero at stop method.

So, if we should match the behavior with mobile and web, we should discard this line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant