feat(connector): postmark email connector #5886
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/connectors/connector-postmark/CHANGELOG.md | 📈 +84 Bytes |
| packages/connectors/connector-postmark/README.md | 📈 +1.98 KB |
| packages/connectors/connector-postmark/logo.svg | 📈 +3.63 KB |
| packages/connectors/connector-postmark/package.json | 📈 +2.03 KB |
| packages/connectors/connector-postmark/src/constant.ts | 📈 +1.34 KB |
| packages/connectors/connector-postmark/src/index.test.ts | 📈 +345 Bytes |
| packages/connectors/connector-postmark/src/index.ts | 📈 +1.67 KB |
| packages/connectors/connector-postmark/src/mock.ts | 📈 +320 Bytes |
| packages/connectors/connector-postmark/src/types.ts | 📈 +1002 Bytes |
|
This solves #5885. |
|
@wangsijie @darcyYe can you guys take a look thx. |
wangsijie
reviewed
May 17, 2024
There was a problem hiding this comment.
This file will be auto generated.
wangsijie
reviewed
May 17, 2024
|
Also, it would be nice if you can make the commits signed. |
|
I will add some basic tests and do signed commits. |
|
Hey just ask our designer to create a logo for you.
|
|
The pnpm lockfile seems to be corrupted. Please try to resolve this issue in order to pass the CI checks. Usually this can be resolved by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented a Postmark email connector that uses Postmark API rather than SMTP. This provides the ability to use templates stored in Postmark instead of the templates stored in JSON.
This is implemented by looking at
connector-sendgrid-emailand implemented it as my understanding of best practices and convensions.Testing
Have a simple uint-test that only checks configuration is valid (as also
connector-sendgrid-emailhas). Else I did manual testing by connecting it in Logto UI and sending a test email trough the UI. Have also tested it in real-world scenarios by connecting it to an email provider.Checklist
.changeset