feat: add phone number validation to user APIs #5882
+282
−139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyYe
force-pushed
the
yemq-log-8880-add-phone-number-validation-to-user-APIs
branch
from
4a854dd
to
13d885a
Compare
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/console/package.json | 📈 +1 Bytes |
| packages/console/src/pages/UserDetails/UserSettings/index.tsx | 📈 +7 Bytes |
| packages/core/src/libraries/user.test.ts | 📈 +158 Bytes |
| packages/core/src/libraries/user.ts | 📈 +912 Bytes |
| packages/core/src/routes-me/social.ts | 📈 +41 Bytes |
| packages/core/src/routes-me/user.ts | 0 Bytes |
| packages/core/src/routes/admin-user/basics.test.ts | 📈 +14 Bytes |
| packages/core/src/routes/admin-user/basics.ts | 📈 +35 Bytes |
| packages/core/src/routes/admin-user/mfa-verifications.test.ts | 📈 +74 Bytes |
| packages/core/src/routes/admin-user/mfa-verifications.ts | 0 Bytes |
| packages/core/src/routes/admin-user/social.test.ts | 📈 +15 Bytes |
| packages/core/src/routes/admin-user/social.ts | 📈 +41 Bytes |
| packages/core/src/routes/interaction/actions/submit-interaction.mfa.test.ts | 📈 +5 Bytes |
| packages/core/src/routes/interaction/actions/submit-interaction.test.ts | 0 Bytes |
| packages/core/src/routes/interaction/actions/submit-interaction.ts | 📈 +45 Bytes |
| packages/core/src/routes/interaction/mfa.test.ts | 📈 +42 Bytes |
| packages/core/src/routes/interaction/mfa.ts | 📈 +13 Bytes |
| packages/core/src/routes/interaction/utils/single-sign-on.test.ts | 0 Bytes |
| packages/core/src/routes/interaction/utils/single-sign-on.ts | 📈 +131 Bytes |
| packages/core/src/routes/interaction/verifications/mfa-payload-verification.test.ts | 📈 +58 Bytes |
| packages/core/src/routes/interaction/verifications/mfa-payload-verification.ts | 📈 +4 Bytes |
| packages/core/src/routes/interaction/verifications/mfa-verification.backup-code.test.ts | 📈 +58 Bytes |
| packages/core/src/routes/interaction/verifications/mfa-verification.test.ts | 📈 +47 Bytes |
| packages/core/src/utils/user.ts | 📈 +751 Bytes |
| packages/experience/package.json | 📈 +40 Bytes |
| packages/experience/src/utils/country-code.ts | 📈 +158 Bytes |
| packages/experience/src/utils/form.ts | 📈 +16 Bytes |
| packages/integration-tests/src/tests/api/admin-user.search.test.ts | 📈 +89 Bytes |
| packages/integration-tests/src/tests/api/admin-user.test.ts | 📈 +269 Bytes |
| packages/integration-tests/src/tests/api/role.user.test.ts | 📈 +254 Bytes |
| packages/shared/package.json | 0 Bytes |
| packages/shared/src/utils/phone.ts | 📈 +786 Bytes |
| pnpm-lock.yaml | 📈 +84 Bytes |
darcyYe
force-pushed
the
yemq-log-8880-add-phone-number-validation-to-user-APIs
branch
4 times, most recently
from
8a52112
to
af48649
Compare
darcyYe
requested review from
wangsijie,
charIeszhao,
gao-sun and
simeng-li
as code owners
simeng-li
reviewed
May 20, 2024
|
|
||
| export { ParseError } from 'libphonenumber-js/mobile'; | ||
|
|
||
| function validateE164Number(value: string): asserts value is E164Number { |
There was a problem hiding this comment.
Align the usage of function declarations and arrow function declarations?
There was a problem hiding this comment.
I tried arrow function declaration and seems it can not make type inference right.
| @@ -106,18 +107,45 @@ export const createUserLibrary = (queries: Queries) => { | |||
| { retries, factor: 0 } // No need for exponential backoff | |||
| ); | |||
|
|
|||
| const updateUserById = async ( | |||
There was a problem hiding this comment.
Should put the validPhoneNumber validation logic at the API koaGuard level?
There was a problem hiding this comment.
I was considering to make this phone number guard at API level. But since the DB insert and update operation could bypass the API-level check since some of them were used in scenarios other than in API handlers.
Make this change on the DB queries/libraries methods IMO should be the safest and the most easy-to-maintain way of doing this.
charIeszhao
approved these changes
May 22, 2024
|
Overall looks good to me. Need to resolve Simeng's comments, though. |
darcyYe
force-pushed
the
yemq-log-8880-add-phone-number-validation-to-user-APIs
branch
from
af48649
to
d832869
Compare
darcyYe
force-pushed
the
yemq-log-8880-add-phone-number-validation-to-user-APIs
branch
from
8ca8932
to
b10179e
Compare
|
This PR is stale because it has been open 10 for days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add phone number validation to user APIs.
insertUserandupdateUserByIdmethods.Testing
Covered by CI.
Checklist
.changeset