feat: automatic social account linking #5881
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
| Name | Diff |
|---|---|
| .changeset/mean-dogs-pump.md | 📈 +562 Bytes |
| packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/SocialSignInForm/index.tsx | 📈 +541 Bytes |
| packages/core/src/mocks/sign-in-experience.ts | 📈 +20 Bytes |
| packages/core/src/queries/sign-in-experience.test.ts | 📈 +87 Bytes |
| packages/experience/src/mocks/logto.tsx | 📈 +40 Bytes |
| packages/experience/src/hooks/use-sie.ts | 📈 +97 Bytes |
| packages/experience/src/pages/SocialSignInWebCallback/use-social-sign-in-listener.ts | 📈 +579 Bytes |
| packages/integration-tests/src/tests/experience/automatic-account-linking.test.ts | 📈 +4.02 KB |
| packages/integration-tests/src/tests/experience/direct-sign-in.test.ts | 📈 +88 Bytes |
| packages/phrases/src/locales/en/translation/admin-console/sign-in-exp/sign-up-and-sign-in.ts | 📈 +393 Bytes |
| packages/schemas/alterations/next-1717567857-social-sign-in-linking.ts | 📈 +476 Bytes |
| packages/schemas/src/foundations/jsonb-types/sign-in-experience.ts | 📈 +475 Bytes |
| packages/schemas/tables/sign_in_experiences.sql | 📈 +77 Bytes |
|
This PR is stale because it has been open 10 for days with no activity. Remove stale label or comment or this will be closed in 5 days. |
gao-sun
force-pushed
the
gao-automatic-social-account-linking
branch
from
eb739ac
to
3bac52c
Compare
gao-sun
force-pushed
the
gao-automatic-social-account-linking
branch
2 times, most recently
from
26c9d3c
to
90ffc0e
Compare
gao-sun
force-pushed
the
gao-automatic-social-account-linking
branch
from
90ffc0e
to
9eb4b24
Compare
gao-sun
requested review from
wangsijie,
charIeszhao and
simeng-li
as code owners
gao-sun
commented
Jun 5, 2024
Comment on lines
+2
to
+4
| "@logto/experience": patch | ||
| "@logto/console": patch | ||
| "@logto/phrases": patch |
There was a problem hiding this comment.
intentionally use as patch since it's more like an improvement
wangsijie
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
per community request, provide an option to skip manually account linking during sign-in
Testing
integration tests added
Checklist
.changeset