Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup code mounting dev scripts #10842

Merged
merged 3 commits into from
May 17, 2024
Merged

Cleanup code mounting dev scripts #10842

merged 3 commits into from
May 17, 2024

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented May 16, 2024

Motivation

We have some make targets and helper scripts that rely on mounting the local code into the right place into the Docker container. We are planning to restructure the code base to change the code layout, and as such these helpers need to be updated.

However, we handle a lot of determining which paths should be mounted into the container with our helper script python -m localstack.dev.run. We should centralise any knowledge of where code is located into a single place, this module, and remove any other commands.

Changes

  • Remove make targets that mount code

Migration guide

  • Makefile#docker-run:
    • run python -m localstack start
  • Makefile#docker-mount-run:
    • run python -m localstack.dev.run
  • Makefile#test-docker*:
    • run python -m localstack.dev.run --mount-entrypoints --mount-dependencies -v $PWD/tests:/opt/code/localstack/tests -- .venv/bin/python -m pytest ...
  • bin/localstack-start-docker-dev.sh:
    • run python -m localstack.dev.run

@simonrw simonrw added the semver: patch Non-breaking changes which can be included in patch releases label May 16, 2024
@simonrw simonrw self-assigned this May 16, 2024
Copy link

S3 Image Test Results (AMD64 / ARM64)

  2 files  ±0    2 suites  ±0   3m 19s ⏱️ +5s
398 tests ±0  346 ✅ ±0   52 💤 ±0  0 ❌ ±0 
796 runs  ±0  692 ✅ ±0  104 💤 ±0  0 ❌ ±0 

Results for commit c1797f5. ± Comparison against base commit 50b2064.

Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 37m 18s ⏱️ + 2m 4s
2 950 tests ±0  2 647 ✅ ±0  303 💤 ±0  0 ❌ ±0 
2 952 runs  ±0  2 647 ✅ ±0  305 💤 ±0  0 ❌ ±0 

Results for commit c1797f5. ± Comparison against base commit 50b2064.

@simonrw simonrw marked this pull request as ready for review May 16, 2024 21:35
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like this PR a lot

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@simonrw simonrw merged commit 4fddd0d into master May 17, 2024
40 checks passed
@simonrw simonrw deleted the cleanup/move-to-dev-script branch May 17, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants