Cleanup code mounting dev scripts #10842
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have some make targets and helper scripts that rely on mounting the local code into the right place into the Docker container. We are planning to restructure the code base to change the code layout, and as such these helpers need to be updated.
However, we handle a lot of determining which paths should be mounted into the container with our helper script
python -m localstack.dev.run
. We should centralise any knowledge of where code is located into a single place, this module, and remove any other commands.Changes
Migration guide
Makefile#docker-run
:python -m localstack start
Makefile#docker-mount-run
:python -m localstack.dev.run
Makefile#test-docker*
:python -m localstack.dev.run --mount-entrypoints --mount-dependencies -v $PWD/tests:/opt/code/localstack/tests -- .venv/bin/python -m pytest ...
bin/localstack-start-docker-dev.sh
:python -m localstack.dev.run