Refactor datastream update checks #958
Open
+64
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to control which datastream update checks to override
surajkn
requested review from
jzakaryan,
shrinandthakkar,
ehoner and
ryannedolan
ehoner
approved these changes
Sep 18, 2023
jogrogan
reviewed
Oct 18, 2023
| + " old: %s new: %s", key, oldDatastream, datastream)); | ||
| } | ||
|
|
||
| if (!_config.getOverrideDatastreamUpdateChecks()) { |
There was a problem hiding this comment.
So this flag only allows you to bypass the destination check? Why is this needed and if it is should we rename it?
There was a problem hiding this comment.
Yes for now we only bypass destination change check. For IPv6, we plan to manually (through brooklin tool command) update destination of the exisiting datastreams, and this check prevents that.
This is only a temporary change. Once IPv6 migration is done we will revert this change. So not a lot of benefit in renaming it if you dont feel too strongly about it
There was a problem hiding this comment.
If the plan is to revert that's fine
jogrogan
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to control which datastream update checks to override
Important: DO NOT REPORT SECURITY ISSUES DIRECTLY ON GITHUB.
For reporting security issues and contributing security fixes,
please, email security@linkedin.com instead, as described in
the contribution guidelines.
Please, take a minute to review the contribution guidelines at:
https://github.com/linkedin/Brooklin/blob/master/CONTRIBUTING.md