-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable changing commit message when using amend #3954
base: main
Are you sure you want to change the base?
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 482a295. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targetsSent with 💌 from NxCloud. |
@JamesHenry I changed the behaviour of --amend in combination with --message so that the message will be overrridden if specified. I think this is a breaking change and therefore not a good solution. What do you think about using another flag like --amendMessage to support amending and overriding the message in one go? |
@fahslaj what do you think? |
Hey @amorscher , I think it's fine to update |
Hi @amorscher just following up on the latest plans for this PR please |
allows overriding of the commit message
Motivation and Context
fixes #3936
How Has This Been Tested?
all tests still pass
Types of changes
Checklist: