-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add migration_table name option #2725
base: main
Are you sure you want to change the base?
Conversation
Tested locally with sqlite by |
Does this seem like a reasonable approach to quickly satisfy the needs outlined in the use cases before I do more things like add tests? If more migration options, or some more refactoring is needed later, it may be warranted to look at refactoring the relationship between the migration and the database connection. They seem too tightly bound when the database connection is required to know about the migration table, sqlx/sqlx-postgres/src/migrate.rs Lines 90 to 111 in d0fbe7f
|
Hey @kriswuollett any updates on this? I would like to see this merged too. |
@abonander, are you willing to work with an externally contributed PR to implement a migration table name option? I assume I'd need to add in schema/table name validation for the new option. Is there some other approach that would be preferred to the rather direct way I implemented the PR? |
+1 @abonander is there any interest on getting @kriswuollett's change reviewed and merged, or potentially helping define what you'd prefer to see? Or is this a non-priority at the moment for launchbadge (which is fine too)? |
Add
migration_table
option to enable sharing a database among multiple apps/clients. It is the responsibility of the user to ensure database permissions for the database role performing the migration is not able affect other co-hosted apps/clients done in separate migration "partitions".