Correctly put terminals into non-capturing groups when combining them #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good change. But I have a feeling this might trigger some hidden bugs in various repos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1414
The core issue is that
A Bgot turned into/{A}{B}/instead of/(?:{A})(?:{B})/. Most of the time, this doesn't matter, however ifBis a manually defined regex, for example/c|d/, the overall regex ended up being/ac|d/, which ofcourse means something else than the BNF was supposed to express.This is technically a breaking change if people were relying on this buggy behavior.