chore: sort categories in recommended app service response #4498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
|
👍
W. Logan Clark
…On Sun, May 19, 2024 at 12:59 AM Yeuoly ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM
—
Reply to this email directly, view it on GitHub
<#4498 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BH6TQ2ZKNHPZPCQ5N3EBS4LZDBLW7AVCNFSM6AAAAABH5RZ2JGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRVGAYTMOJUHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
| @@ -95,7 +95,7 @@ def _fetch_recommended_apps_from_db(cls, language: str) -> dict: | |||
|
|
|||
| categories.add(recommended_app.category) # add category to categories | |||
|
|
|||
| return {'recommended_apps': recommended_apps_result, 'categories': list(categories)} | |||
| return {'recommended_apps': recommended_apps_result, 'categories': sorted(list(categories))} | |||
There was a problem hiding this comment.
Suggested change
| return {'recommended_apps': recommended_apps_result, 'categories': sorted(list(categories))} | |
| return {'recommended_apps': recommended_apps_result, 'categories': sorted(categories)} |
Simply sort the set, and the returned value is in list type. eg.
There was a problem hiding this comment.
list(categories) duplicate removal, and sorted by it.
TinsFox
pushed a commit
to TinsFox/dify
that referenced
this pull request
May 20, 2024
iamjoel
pushed a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.