Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: passing in 0 as a numeric variable will be converted to null #4148

Merged
merged 1 commit into from
May 7, 2024

Conversation

takatost
Copy link
Collaborator

@takatost takatost commented May 7, 2024

Description

fix: passing in 0 as a numeric variable will be converted to null

Fixes #4096

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual test

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 7, 2024
@takatost takatost self-assigned this May 7, 2024
@dosubot dosubot bot added 🐍 python Pull requests that update Python code 🐞 bug Something isn't working labels May 7, 2024
@takatost takatost merged commit c2f0f95 into main May 7, 2024
10 checks passed
@takatost takatost deleted the fix/number-var-npe branch May 7, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🐍 python Pull requests that update Python code size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
1 participant