Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: test CodeExecutor with code templates and extract CodeLanguage enum #4098

Merged
merged 4 commits into from May 7, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented May 5, 2024

Description

  • add tests for CodeExecutor with code templates of different languages , covering Python, javascript and Jinja2
  • extract CodeLanguage enum in CodeExecutor and the mapping to running language and code template transformers.
  • fix typo of test_code_jinja2

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@bowenliang123 bowenliang123 marked this pull request as ready for review May 5, 2024 18:51
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. ☕️ javascript Pull requests that update Javascript code 🐍 python Pull requests that update Python code 💪 enhancement New feature or request labels May 5, 2024
@bowenliang123
Copy link
Contributor Author

bowenliang123 commented May 6, 2024

cc @Yeuoly @takatost

Copy link
Collaborator

@Yeuoly Yeuoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 7, 2024
@Yeuoly Yeuoly merged commit 049abd6 into langgenius:main May 7, 2024
14 checks passed
@bowenliang123 bowenliang123 deleted the test-codetemp branch May 7, 2024 05:43
@bowenliang123
Copy link
Contributor Author

Thanks.

rennokki pushed a commit to rennokki/dify that referenced this pull request May 9, 2024
@takatost takatost mentioned this pull request May 9, 2024
evnydd0sf pushed a commit to evnydd0sf/dify that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request ☕️ javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer 🐍 python Pull requests that update Python code size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants