New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve: test CodeExecutor with code templates and extract CodeLanguage enum #4098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenliang123
force-pushed
the
test-codetemp
branch
from
May 5, 2024 16:26
226837b
to
6729425
Compare
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
☕️ javascript
Pull requests that update Javascript code
🐍 python
Pull requests that update Python code
💪 enhancement
New feature or request
labels
May 5, 2024
bowenliang123
force-pushed
the
test-codetemp
branch
from
May 6, 2024 01:02
2bcbeb2
to
af709de
Compare
bowenliang123
force-pushed
the
test-codetemp
branch
from
May 6, 2024 16:01
af709de
to
02ec1c8
Compare
Yeuoly
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks. |
rennokki
pushed a commit
to rennokki/dify
that referenced
this pull request
May 9, 2024
Merged
evnydd0sf
pushed a commit
to evnydd0sf/dify
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💪 enhancement
New feature or request
☕️ javascript
Pull requests that update Javascript code
lgtm
This PR has been approved by a maintainer
🐍 python
Pull requests that update Python code
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
test_code_jinja2
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsoptional
I have made corresponding changes to the documentationoptional
I have added tests that prove my fix is effective or that my feature worksoptional
New and existing unit tests pass locally with my changes