Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated search1api as built-in tool #4086

Closed
wants to merge 2 commits into from
Closed

Conversation

fatwang2
Copy link

@fatwang2 fatwang2 commented May 4, 2024

Description

Integrated search1api as built-in tool. Search1API is a search aggregation service that allows you to quickly and cost-effectively access Google, Bing, DuckDuckGo searches. It also supports specialized features such as searching for images while searching or crawling at the same time, specifically developed for LLMs.

Type of Change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  1. Buy the key on search1api, it has a 1 day free trail now
  2. Add Search1API Search tool
  3. Please fill in the authorization code you obtained from your purchase, pass the verification, and start using it.

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🔨 feat:tools Tools for agent, function call related stuff. labels May 4, 2024
@Yeuoly
Copy link
Collaborator

Yeuoly commented May 5, 2024

Thanks for submitting your PR! We appreciate your effort, but this tool doesn't quite fit our current plans, Bing/Google/DuckDuckGo have been officially supported though.

@Yeuoly Yeuoly closed this May 5, 2024
@fatwang2
Copy link
Author

fatwang2 commented May 5, 2024 via email

@fatwang2
Copy link
Author

fatwang2 commented May 5, 2024

I would like to clarify that the Google search integrated in your system is not official, but rather serpapi, which is a commercial product similar to my search1api. I don't quite understand why you consider this as an official Google service and use the Google logo. Additionally, there is currently no support for DuckDuckGo tools.

CleanShot 2024-05-05 at 16 54 46@2x

@takatost
Copy link
Collaborator

takatost commented May 5, 2024

Hey @fatwang2, we noticed that your online service doesn't have any information about the entity responsible. In order to be responsible to our users, we need to review the qualifications of your online service to prevent personal information leakage. If you are connecting this tool to an open-source project, that's totally acceptable to us. 🙂

@Yeuoly
Copy link
Collaborator

Yeuoly commented May 5, 2024

Hello, did you misunderstand? This plugin is not purely aggregative, it also has a lot of customization features, similar to search services like Tavily and Serp

On Sun, May 5, 2024 at 3:10 PM Yeuoly @.> wrote: Thanks for submitting your PR! We appreciate your effort, but this tool doesn't quite fit our current plans, Bing/Google/DuckDuckGo have been officially supported though. — Reply to this email directly, view it on GitHub <#4086 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A77NZSRVNP6C25KLWWLDLUDZAXLNJAVCNFSM6AAAAABHHAAGAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUGY3DANJXGE . You are receiving this because you authored the thread.Message ID: @.>

Sorry for misunderstanding, I apologize for my rough judgment, it looks like a funneling tool as we have encountered many similar tools before, and I do not notice that it's an open-source project.
But for your online service, especially for the landing page, I suggest that adding an entity responsible, and support self-deployment instance integrating like SearXNG.

@Yeuoly Yeuoly reopened this May 5, 2024
@fatwang2
Copy link
Author

fatwang2 commented May 5, 2024

I have not run a company,the API is just my personal works with the help of AI,and it is not open source but commercial.I am not sure what should I offer you to prove myself, have you research all the tools you have built in?

@takatost
Copy link
Collaborator

takatost commented May 5, 2024

I have not run a company,the API is just my personal works with the help of AI,and it is not open source but commercial.I am not sure what should I offer you to prove myself, have you research all the tools you have built in?

Yes, that's right.
If the tool corresponds to a SaaS product, our principle is that the other party needs to disclose the operating entity and privacy policy, this is a basic compliance requirement.
If you are running a legitimate business, please confidently disclose it to your users, thank you very much! 🤝

@fatwang2
Copy link
Author

fatwang2 commented May 5, 2024

So you don't accept commercial products from independent developers, right?

@takatost
Copy link
Collaborator

takatost commented May 5, 2024

pt commercial products from independent developers, right?

We are allowed, but whether it's a company or individual-operated service, we need to ensure it complies with business regulations before we can accept it. It's a basic legal principle.

@takatost
Copy link
Collaborator

takatost commented May 5, 2024

Your SaaS service should at least provide a privacy policy and contact information, so users can understand how you handle user data.

@fatwang2
Copy link
Author

fatwang2 commented May 5, 2024

I have wrote these when built my website,but I am not sure people will see these.privacy
terms

@takatost
Copy link
Collaborator

takatost commented May 5, 2024

I have wrote these when built my website,but I am not sure people will see these.privacy terms

You need to reference them prominently on the website.

@fatwang2
Copy link
Author

fatwang2 commented May 5, 2024

okay,I will add them on my website this week

@fatwang2
Copy link
Author

fatwang2 commented May 6, 2024

CleanShot 2024-05-07 at 01 32 38@2x

is it okay?

@takatost
Copy link
Collaborator

takatost commented May 7, 2024

Could you please fix the lint issue?
P. S. Is the spelling of "Privacy" wrong?

@fatwang2
Copy link
Author

fatwang2 commented May 7, 2024

fixed it, sorry for that

@takatost
Copy link
Collaborator

takatost commented May 8, 2024

The checks below are still failing.

@SebastjanPrachovskij
Copy link

SebastjanPrachovskij commented May 9, 2024

Hey Dify team,

I’m a Software Engineer from SearchApi, LLC. Our brand, recognized in the search service domain (SERP), owns prominent domains like SearchAPI.com, SearchAPI.io, and SearchAPI.ai. We have successful integrations with LangChain, Flowise, and Haystack, which are well-known among our users. Given this established presence and our plans to integrate into the Dify project, we are concerned about the potential confusion the similarly named Search1API could cause.

We suggest considering a name change for Search1API to ensure clear differentiation between our services. This step is crucial to avoid brand confusion and maintain the integrity of both entities in the platform.

Additionally, it has come to our attention that Search1API’s Terms of Service do not disclose the responsible entity. Transparency about who operates a service is essential for user trust and compliance with legal standards.

We are enthusiastic about our continued collaborations within the tech community and are committed to maintaining clear and distinct brand identities for all involved.

Thank you for your attention to these important issues.

@fatwang2
Copy link
Author

fatwang2 commented May 9, 2024 via email

@fatwang2 fatwang2 closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 feat:tools Tools for agent, function call related stuff. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants