New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: combine and send ci coverage report to PR comment #3957
Conversation
This reverts commit 6ae8880.
The error Docs for enabling or managing Github workflow permissions: |
cc @crazywoola |
This comment was marked as off-topic.
This comment was marked as off-topic.
This PR is not inventing the wheel again, but generally reused the pytest framework and coverage outputs. And it's not introducing outside dependencies or cost.
If Dify project decide to connect to third-party platform like |
This comment was marked as off-topic.
This comment was marked as off-topic.
Why are you so aggressive in your sords to the goal while ignoring the key points I just mentioned about the balance of third-party platform constraint and the feasibility? Is that |
This comment was marked as off-topic.
This comment was marked as off-topic.
PLEASE at least respect the Dify project and the Dify community behaviour code. |
Description
coverage
to run pytests and cobine the coverage report.python-coverage
(https://github.com/marketplace/actions/python-coverage) to send the coverage report to PR's comment, including the overall coverage rate, the coverage of modified or new files.eg. (https://github.com/marketplace/actions/python-coverage#pr-message--job-summary-)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsoptional
I have made corresponding changes to the documentationoptional
I have added tests that prove my fix is effective or that my feature worksoptional
New and existing unit tests pass locally with my changes