Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use flask-restx instead in service API #3920

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 7 additions & 4 deletions api/controllers/service_api/__init__.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
from flask import Blueprint

from libs.external_api import ExternalApi
from libs.flask_restx_external_api import FlaskRestxExternalApi

bp = Blueprint('service_api', __name__, url_prefix='/v1')
api = ExternalApi(bp)
from .app import api as app_ns
from .dataset import api as dataset_ns

bp = Blueprint('service_api', __name__, url_prefix='/v1')
api = FlaskRestxExternalApi(bp, doc='/docs/', title='Dify OpenAPI', version='1.0', description='Dify OpenAPI')
api.add_namespace(app_ns)
api.add_namespace(dataset_ns)

from . import index
from .app import app, audio, completion, conversation, file, message, workflow
from .dataset import dataset, document, segment
3 changes: 3 additions & 0 deletions api/controllers/service_api/app/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
from flask_restx import Namespace

api = Namespace('app', path='/', description='App Service API')
6 changes: 3 additions & 3 deletions api/controllers/service_api/app/app.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@

from flask import current_app
from flask_restful import Resource, fields, marshal_with
from flask_restx import Resource, fields, marshal_with

from controllers.service_api import api
from controllers.service_api.app import api
from controllers.service_api.app.error import AppUnavailableError
from controllers.service_api.wraps import validate_app_token
from models.model import App, AppMode
Expand Down Expand Up @@ -96,7 +96,7 @@ def get(self, app_model: App):
return {
'name':app_model.name,
'description':app_model.description
}
}


api.add_resource(AppParameterApi, '/parameters')
Expand Down
4 changes: 2 additions & 2 deletions api/controllers/service_api/app/audio.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import logging

from flask import request
from flask_restful import Resource, reqparse
from flask_restx import Resource, reqparse
from werkzeug.exceptions import InternalServerError

import services
from controllers.service_api import api
from controllers.service_api.app import api
from controllers.service_api.app.error import (
AppUnavailableError,
AudioTooLargeError,
Expand Down
4 changes: 2 additions & 2 deletions api/controllers/service_api/app/completion.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import logging

from flask_restful import Resource, reqparse
from flask_restx import Resource, reqparse
from werkzeug.exceptions import InternalServerError, NotFound

import services
from controllers.service_api import api
from controllers.service_api.app import api
from controllers.service_api.app.error import (
AppUnavailableError,
CompletionRequestError,
Expand Down
6 changes: 3 additions & 3 deletions api/controllers/service_api/app/conversation.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
from flask_restful import Resource, marshal_with, reqparse
from flask_restful.inputs import int_range
from flask_restx import Resource, marshal_with, reqparse
from flask_restx.inputs import int_range
from werkzeug.exceptions import NotFound

import services
from controllers.service_api import api
from controllers.service_api.app import api
from controllers.service_api.app.error import NotChatAppError
from controllers.service_api.wraps import FetchUserArg, WhereisUserArg, validate_app_token
from core.app.entities.app_invoke_entities import InvokeFrom
Expand Down
4 changes: 2 additions & 2 deletions api/controllers/service_api/app/file.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
from flask import request
from flask_restful import Resource, marshal_with
from flask_restx import Resource, marshal_with

import services
from controllers.service_api import api
from controllers.service_api.app import api
from controllers.service_api.app.error import (
FileTooLargeError,
NoFileUploadedError,
Expand Down
6 changes: 3 additions & 3 deletions api/controllers/service_api/app/message.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import logging

from flask_restful import Resource, fields, marshal_with, reqparse
from flask_restful.inputs import int_range
from flask_restx import Resource, fields, marshal_with, reqparse
from flask_restx.inputs import int_range
from werkzeug.exceptions import BadRequest, InternalServerError, NotFound

import services
from controllers.service_api import api
from controllers.service_api.app import api
from controllers.service_api.app.error import NotChatAppError
from controllers.service_api.wraps import FetchUserArg, WhereisUserArg, validate_app_token
from core.app.entities.app_invoke_entities import InvokeFrom
Expand Down
4 changes: 2 additions & 2 deletions api/controllers/service_api/app/workflow.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import logging

from flask_restful import Resource, reqparse
from flask_restx import Resource, reqparse
from werkzeug.exceptions import InternalServerError

from controllers.service_api import api
from controllers.service_api.app import api
from controllers.service_api.app.error import (
CompletionRequestError,
NotWorkflowAppError,
Expand Down
3 changes: 3 additions & 0 deletions api/controllers/service_api/dataset/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
from flask_restx import Namespace

api = Namespace('dataset', path='/', description='Dataset Service API')
4 changes: 2 additions & 2 deletions api/controllers/service_api/dataset/dataset.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
from flask import request
from flask_restful import marshal, reqparse
from flask_restx import marshal, reqparse

import services.dataset_service
from controllers.service_api import api
from controllers.service_api.dataset import api
from controllers.service_api.dataset.error import DatasetNameDuplicateError
from controllers.service_api.wraps import DatasetApiResource
from core.model_runtime.entities.model_entities import ModelType
Expand Down
4 changes: 2 additions & 2 deletions api/controllers/service_api/dataset/document.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import json

from flask import request
from flask_restful import marshal, reqparse
from flask_restx import marshal, reqparse
from sqlalchemy import desc
from werkzeug.exceptions import NotFound

import services.dataset_service
from controllers.service_api import api
from controllers.service_api.app.error import ProviderNotInitializeError
from controllers.service_api.dataset import api
from controllers.service_api.dataset.error import (
ArchivedDocumentImmutableError,
DocumentIndexingError,
Expand Down
4 changes: 2 additions & 2 deletions api/controllers/service_api/dataset/segment.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
from flask_login import current_user
from flask_restful import marshal, reqparse
from flask_restx import marshal, reqparse
from werkzeug.exceptions import NotFound

from controllers.service_api import api
from controllers.service_api.app.error import ProviderNotInitializeError
from controllers.service_api.dataset import api
from controllers.service_api.wraps import (
DatasetApiResource,
cloud_edition_billing_knowledge_limit_check,
Expand Down
16 changes: 0 additions & 16 deletions api/controllers/service_api/index.py

This file was deleted.

2 changes: 1 addition & 1 deletion api/controllers/service_api/wraps.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

from flask import current_app, request
from flask_login import user_logged_in
from flask_restful import Resource
from flask_restx import Resource
from pydantic import BaseModel
from werkzeug.exceptions import Forbidden, NotFound, Unauthorized

Expand Down
2 changes: 1 addition & 1 deletion api/fields/conversation_fields.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from flask_restful import fields
from flask_restx import fields

from fields.member_fields import simple_account_fields
from libs.helper import TimestampField
Expand Down
2 changes: 1 addition & 1 deletion api/fields/file_fields.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from flask_restful import fields
from flask_restx import fields

from libs.helper import TimestampField

Expand Down
115 changes: 115 additions & 0 deletions api/libs/flask_restx_external_api.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
import re
import sys

from flask import current_app, got_request_exception
from flask_restx import Api
from werkzeug.datastructures import Headers
from werkzeug.exceptions import HTTPException
from werkzeug.http import HTTP_STATUS_CODES


class FlaskRestxExternalApi(Api):

def handle_error(self, e):
"""Error handler for the API transforms a raised exception into a Flask
response, with the appropriate HTTP status code and body.

:param e: the raised Exception object
:type e: Exception

"""
got_request_exception.send(current_app, exception=e)

headers = Headers()
if isinstance(e, HTTPException):
if e.response is not None:
resp = e.get_response()
return resp

status_code = e.code
default_data = {
'code': re.sub(r'(?<!^)(?=[A-Z])', '_', type(e).__name__).lower(),
'message': getattr(e, 'description', HTTP_STATUS_CODES.get(status_code, '')),
'status': status_code
}

if default_data['message'] and default_data['message'] == 'Failed to decode JSON object: Expecting value: line 1 column 1 (char 0)':
default_data['message'] = 'Invalid JSON payload received or JSON payload is empty.'

headers = e.get_response().headers
elif isinstance(e, ValueError):
status_code = 400
default_data = {
'code': 'invalid_param',
'message': str(e),
'status': status_code
}
else:
status_code = 500
default_data = {
'message': HTTP_STATUS_CODES.get(status_code, ''),
}

# Werkzeug exceptions generate a content-length header which is added
# to the response in addition to the actual content-length header
# https://github.com/flask-restful/flask-restful/issues/534
remove_headers = ('Content-Length',)

for header in remove_headers:
headers.pop(header, None)

data = getattr(e, 'data', default_data)

# record the exception in the logs when we have a server error of status code: 500
if status_code and status_code >= 500:
exc_info = sys.exc_info()
if exc_info[1] is None:
exc_info = None
current_app.log_exception(exc_info)

if status_code == 406 and self.default_mediatype is None:
# if we are handling NotAcceptable (406), make sure that
# make_response uses a representation we support as the
# default mediatype (so that make_response doesn't throw
# another NotAcceptable error).
supported_mediatypes = list(self.representations.keys()) # only supported application/json
fallback_mediatype = supported_mediatypes[0] if supported_mediatypes else "text/plain"
data = {
'code': 'not_acceptable',
'message': data.get('message')
}
resp = self.make_response(
data,
status_code,
headers,
fallback_mediatype = fallback_mediatype
)
elif status_code == 400:
if isinstance(data.get('message'), dict):
param_key, param_value = list(data.get('message').items())[0]
data = {
'code': 'invalid_param',
'message': param_value,
'params': param_key
}
else:
if 'code' not in data:
data['code'] = 'unknown'

resp = self.make_response(data, status_code, headers)
else:
if 'code' not in data:
data['code'] = 'unknown'

resp = self.make_response(data, status_code, headers)

if status_code == 401:
resp = self.unauthorized(resp)
return resp

def render_root(self):
return {
"welcome": "Dify OpenAPI",
"api_version": "v1",
"server_version": current_app.config['CURRENT_VERSION']
}
2 changes: 1 addition & 1 deletion api/libs/helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from zoneinfo import available_timezones

from flask import Response, stream_with_context
from flask_restful import fields
from flask_restx import fields


def run(script):
Expand Down
1 change: 1 addition & 0 deletions api/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Flask-Compress~=1.14
flask-login~=0.6.3
flask-migrate~=4.0.5
flask-restful~=0.3.10
flask-restx~=1.3.0
flask-cors~=4.0.0
gunicorn~=22.0.0
gevent~=23.9.1
Expand Down