perf(scores): remove fk constraint from traceId and observationId on scores, change to projectId #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
maxdeichmann
approved these changes
May 9, 2024
Base automatically changed from
marc/lfe-1114-step2-backfill-projectid-on-score
to
main
May 9, 2024 18:29
* chore(scores): drop fk on traces and observations * trpc update * push
marcklingen
commented
May 13, 2024
|
fixed api auth, should allow access to scores with |
...ations/20240513082203_scores_unique_id_and_projectid_instead_of_id_and_traceid/migration.sql
Outdated
Show resolved
Hide resolved
marcklingen
commented
May 15, 2024
marcklingen
commented
May 15, 2024
There was a problem hiding this comment.
@maxdeichmann I adapted the tests to the desired change of this PR. can you check and approve this change?
marcklingen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency: #2014, both PRs should be merged at the same time.