feat(ui): add theming #1998
feat(ui): add theming #1998
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CONTRIBUTING.md
Outdated
|
|
||
| At Langfuse, we utilize CSS variables to manage our theme settings across the platform. | ||
|
|
||
| Our theming approach is utilizing separate CSS variables for background (--background) and foreground (--foreground) colors. We recommend using HSL values for these colors to enhance user interface consistency and customization capabilities. |
There was a problem hiding this comment.
I'd directly reference the color palette used by shadcn/ui as we probably fully rely on that naming/convention. What do you think?
There was a problem hiding this comment.
Makes sense. I added a change explicitly mentioning and linking shadcn theming docs.
Co-authored-by: Marc Klingen <git@marcklingen.com>
| - Primary Color: `primary` | ||
| - Accents: `primary-accent` | ||
| - Selectable Items: `input` | ||
| - Link Background: `muted-indigo` |
There was a problem hiding this comment.
can we switch to some template here as well? I though we use some [template]\80 for these
also, other colors (red, yellow, green) missing
| 1. Global Definitions: Add new CSS variable definitions in the global.css file. | ||
| 2. Tailwind Configuration: Reflect these new colors in the tailwind.config.js to maintain alignment with Tailwind's utility classes. | ||
|
|
||
| ### Utility Classes |
There was a problem hiding this comment.
I'd add a couple of more words to each with examples, to me it is not 100% clear what accent, main content etc means. All contributors need to easily understand which colors to apply to which parts of their components
No description provided.