Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prompts): add table to compare metrics across prompt versions, [promptName]/metrics #1991

Merged
merged 29 commits into from May 14, 2024
Merged

feat(prompts): add table to compare metrics across prompt versions, [promptName]/metrics #1991

merged 29 commits into from May 14, 2024

Conversation

marliessophie
Copy link
Contributor

@marliessophie marliessophie commented May 7, 2024 •
edited

No description provided.

@vercel Vercel
Copy link

vercel bot commented May 7, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langfuse-cloud ✅ Ready (Inspect) Visit Preview May 14, 2024 8:09pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
langfuse-cloud-us ⬜️ Ignored (Inspect) May 14, 2024 8:09pm

@marliessophie marliessophie self-assigned this May 7, 2024
@marliessophie
fix: metrics query
5efa0d9 
* feat: add formatting to table cells
@marliessophie marliessophie marked this pull request as ready for review May 10, 2024 16:23
marliessophie
marliessophie commented May 10, 2024
View reviewed changes
Copy link
Contributor Author

@marliessophie marliessophie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI bei gewissen screen sizes springen die <Tabs> zwischen editor und table view. Kann ich in einem follow-up verbessern.

Screenshot 2024-05-10 at 18 28 31

marcklingen
marcklingen approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@marcklingen marcklingen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome, we can fix the ui glitch on mobile with a more generalized solution soon.

i just renamed this to metrics after chatting with @clemra as this more accurately reflects why this table is useful

@marcklingen marcklingen changed the title feat: add table view to compare metrics and scores across prompt versions feat: add table to compare metrics across prompt versions, '[promptName]/metrics` May 14, 2024
@marcklingen marcklingen changed the title feat: add table to compare metrics across prompt versions, '[promptName]/metrics` feat(prompts): add table to compare metrics across prompt versions, [promptName]/metrics May 14, 2024
@marcklingen marcklingen enabled auto-merge (squash) May 14, 2024 20:07
@marcklingen marcklingen merged commit 2990767 into main May 14, 2024
12 of 14 checks passed
@marcklingen marcklingen deleted the marlies/lfe-975 branch May 14, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcklingen marcklingen marcklingen approved these changes

Assignees

@marliessophie marliessophie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marliessophie @marcklingen @maxdeichmann