Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): allow filtering for null trace names #1245

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

khareyash05
Copy link
Contributor

@khareyash05 khareyash05 commented Feb 23, 2024

What does this PR do?

Allow filtering for null trace names in traces sections

Since naming null traces to null could cause conflicts while searching for traces. Therefore IMHO we should replace null traces with [no-trace-name]

Fixes #1198

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • This change requires a documentation update

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

vercel bot commented Feb 23, 2024

@khareyash05 is attempting to deploy a commit to the langfuse Team on Vercel.

A member of the Team first needs to authorize it.

@marcklingen marcklingen self-requested a review April 8, 2024 13:33
@khareyash05 khareyash05 requested a review from a team as a code owner April 8, 2024 13:36
@marcklingen
Copy link
Member

The filter does not work for me, can you confirm that it works for you? I cannot filter for name=null in trace-table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(ui): allow filtering for null values (trace.name)
2 participants