Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Langfuse SDKs should log an error and be disabled when keys are not provided #1910

Closed
marcklingen opened this issue Apr 29, 2024 Discussed in #1488 · 3 comments
Closed
Assignees

Comments

@marcklingen
Copy link
Member

Discussed in https://github.com/orgs/langfuse/discussions/1488

Originally posted by MrMojoR March 25, 2024

Describe the feature or potential improvement

It would be great if Langfuse functionality can be turned off. I use the decorators, and if the Langfuse backend is not configured it logs a lot of errors, so I would like to have a parameter, where I can turn off the functionality so I won't get errors when the parameters are not configured. Thanks!

Additional information

No response

@marcklingen marcklingen changed the title Langfuse SDKs should log an error and be disabled when keys are not provided feat: Langfuse SDKs should log an error and be disabled when keys are not provided Apr 30, 2024
@marcklingen
Copy link
Member Author

See discussion in #1829 for additional context

@Jqnxyz
Copy link

Jqnxyz commented May 9, 2024

+1 For this feature. It's incredibly tough to push for Langfuse adoption for projects when devs who don't need tracing on local machine have no choice but to endure the barrage of errors. It would be great if Langfuse disables itself when either public/secret keys are missing (as suggested).

Though ideally I'd like to see Langfuse's "magic" enabled explicitly, allowing us to configure the "global" langfuse instance that's used in things like @observe decorators. See Sentry's SDK for a good example
i.e.

import sentry_sdk

sentry_sdk.init(
    enable_tracing=True,
)

@marcklingen
Copy link
Member Author

This is work in progress including a disabled flag to turn off the "magic", thanks for your comment @Jqnxyz

@hassiebp hassiebp reopened this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants