Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: When envs are not set correctly, SDKs should log an error instead of throwing an exception #598

Closed
marcklingen opened this issue Nov 29, 2023 · 6 comments
Closed

feat: When envs are not set correctly, SDKs should log an error instead of throwing an exception #598

marcklingen opened this issue Nov 29, 2023 · 6 comments
Labels
good first issue Good for newcomers prio-low sdk-js sdk-python work-in-progress

Comments

@marcklingen
Copy link
Member

No description provided.

@gokuljs
Copy link
Contributor

gokuljs commented Dec 1, 2023 •
edited

i will pick this up @marcklingen

@marcklingen
Copy link
Member Author

Thanks @gokuljs! Let me know if you have any questions when making changes to the two sdks

@gokuljs
Copy link
Contributor

gokuljs commented Dec 1, 2023

will do @marcklingen

@Ritish134
Copy link

@marcklingen May you please clarify on which files changes are to be done?

@shashankshet
Copy link

Hello @marcklingen ,

I updated the python-sdk to handle when envs are not set. Please let me know your suggestions on this fix

langfuse/langfuse-python#299

@marcklingen
Copy link
Member Author

Moving this to #1910

@marcklingen marcklingen closed this as not planned Won't fix, can't repro, duplicate, stale Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers prio-low sdk-js sdk-python work-in-progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@marcklingen @shashankshet @gokuljs @Ritish134