fix: skip langchain prompt formatting for non-langfuse variables #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxdeichmann
approved these changes
May 14, 2024
hassiebp
force-pushed
the
hassieb/lfe-935-langchain-jinja2-support-in-prompts
branch
from
913f478
to
7e1ca62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users have Jinja2 templates in their prompts, these will also get transformed to langchain variables when calling
get_langchain_prompton the langfuse prompt. This PR fixes the behavior to only transform variables that are langfuse prompt variables (alphabetical characters or underscores).