[FEATURE] Allow passing Image or collections of Image into AI Service method #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmacphail
changed the title
ashimoon
reviewed
May 29, 2024
| @@ -47,6 +53,18 @@ interface AiService { | |||
| @UserMessage("What is the {{it}} of {{country}}?") | |||
| String chat7(@V("it") String it, @V("country") String country); | |||
|
|
|||
| @UserMessage("Count the number of cars in this image") | |||
| String chat8(@UserMessage ImageContent imageContent); | |||
There was a problem hiding this comment.
Perhaps consider returning int here since the expected output should always be an int.
|
I believe this is very interesting. @langchain4j what is your take on this? Do you have something else in mind or is does this match what you were planning to do in the future? |
|
@geoand seems good, but need to test all the possible combinations before merging: single image, multiple images, image+text, multiple images+text, etc |
|
I can expand the test, I will first work on a list of all needed combination to support. |
|
Makes sense, thanks for the explanation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#938
Change
Add the ability to pass Image and ImageContent to AIServices.
Please note that I only added unit tests so far, as I'm looking for comments on style before continuing further.
General checklist
Checklist for adding new model integration
Checklist for adding new embedding store integration
{NameOfIntegration}EmbeddingStoreITthat extends from eitherEmbeddingStoreITorEmbeddingStoreWithFilteringITChecklist for changing existing embedding store integration
{NameOfIntegration}EmbeddingStoreworks correctly with the data persisted using the latest released version of LangChain4j