Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose use_index in LanceDB OSS #560

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

feat: expose use_index in LanceDB OSS #560

wants to merge 9 commits into from

Conversation

wjones127
Copy link
Contributor

@wjones127 wjones127 commented Oct 13, 2023 •
edited

Closes #535

AyushExel and others added 7 commits October 8, 2023 23:11
@AyushExel @chebbyChefNEQ
@wjones127 @changhiskhan @rok
feat: telemetry, error tracking, CLI & config manager (#538)
a1377af 
Co-authored-by: Lance Release <lance-dev@lancedb.com>
Co-authored-by: Rob Meng <rob.xu.meng@gmail.com>
Co-authored-by: Will Jones <willjones127@gmail.com>
Co-authored-by: Chang She <759245+changhiskhan@users.noreply.github.com>
Co-authored-by: rmeng <rob@lancedb.com>
Co-authored-by: Chang She <chang@lancedb.com>
Co-authored-by: Rok Mihevc <rok@mihevc.org>
@ankrgyl
Use query.limit(..) in README (#543)
ababc3f 
If you run the README javascript example in typescript, it complains
that the type of limit is a function and cannot be set to a number.
@changhiskhan
feat: add to_list and to_pandas api's (#556)
e1ae2bc 
Add `to_list` to return query results as list of python dict (so we're
not too pandas-centric). Closes #555

Add `to_pandas` API and add deprecation warning on `to_df`. Closes #545

Co-authored-by: Chang She <chang@lancedb.com>
@AyushExel
[Docs] Improve visibility of table ops (#553)
e41894b 
A little verbose, but better than being non-discoverable 
![Screenshot from 2023-10-11
16-26-02](https://github.com/lancedb/lancedb/assets/15766192/9ba539a7-0cf8-4d9e-94e7-ce5d37c35df0)
@wjones127
feat: cleanup and compaction (#518)
db7bdef 
#488
@AyushExel
Add cohere embedding function (#550)
683824f
@wjones127
feat: expose use_index in LanceDB OSS
f9ccefb
wjones127
wjones127 commented Oct 13, 2023
View reviewed changes
python/lancedb/table.py
Comment on lines +562 to +563
"append", which inserts new rows, and "overwrite", which replaces
the entire content of the table with the new rows.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by change based on user feedback in discord. In retrospect, Table.add(mode="overwrite") is a little confusing, since add implies append. Perhaps we should make a separate Table.overwrite() method?

@wjones127
Copy link
Contributor Author

It appears in Node that Cloud will just ignore the use_index parameter here:

lancedb/node/src/remote/index.ts

Lines 96 to 104 in 683824f

const data = await this._client.search(
this._name,
queryVector,
(this as any)._limit,
(this as any)._nprobes,
(this as any)._refineFactor,
(this as any)._select,
(this as any)._filter
)

Maybe I should do that in Python too?

alexkohler pushed a commit to alexkohler/lancedb that referenced this pull request Apr 20, 2024
@eddyxu
Fix missing duckdb symbol on Linux (lancedb#560)
c0adb26 
fix missing symbol on linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose use_index in Python
4 participants
@wjones127 @AyushExel @ankrgyl @changhiskhan