Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add --kubeconfig arg to the helm chart #6448

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feat: add --kubeconfig arg to the helm chart #6448

wants to merge 1 commit into from

Conversation

moki1202
Copy link

Fixes #6098

@moki1202
added --kubeconfig arg to the helm chart
1a56dcf 
Signed-off-by: Shashank <shashanksingh819@gmail.com>
@moki1202 moki1202 changed the title added --kubeconfig arg to the helm chart Feat: add --kubeconfig arg to the helm chart Jan 18, 2024
@moki1202 moki1202 marked this pull request as ready for review January 18, 2024 09:50
@moki1202
Copy link
Author

@wonderflow @chivalryq can you please take a look at this PR. I'll resolve any comments ASAP :). Apologies for the bother.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barnettZQG barnettZQG Awaiting requested review from barnettZQG barnettZQG is a code owner

@wonderflow wonderflow Awaiting requested review from wonderflow wonderflow is a code owner

@leejanee leejanee Awaiting requested review from leejanee leejanee is a code owner

@Somefive Somefive Awaiting requested review from Somefive Somefive is a code owner

@jefree-cat jefree-cat Awaiting requested review from jefree-cat jefree-cat is a code owner

@FogDong FogDong Awaiting requested review from FogDong FogDong is a code owner

@wangyikewxgm wangyikewxgm Awaiting requested review from wangyikewxgm wangyikewxgm is a code owner

@chivalryq chivalryq Awaiting requested review from chivalryq chivalryq is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please add the --kubeconfig arg to the helm chart (kube-webhook-certgen) so we can point to external cluster
1 participant
@moki1202