Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO: Update cni-plugins v1.4.1 SHAs #18896

Merged
merged 2 commits into from
May 20, 2024
Merged

ISO: Update cni-plugins v1.4.1 SHAs #18896

merged 2 commits into from
May 20, 2024

Conversation

spowelljr
Copy link
Member

ISO builds now fail with the following error:

22:23:50 ERROR: while checking hashes from /home/jenkins/go/src/k8s.io/minikube/deploy/iso/minikube-iso/arch/x86_64/package/cni-plugins-latest//cni-plugins-latest.hash
22:23:50 ERROR: cni-plugins-linux-amd64-v1.4.1.tgz has wrong sha256 hash:
22:23:50 ERROR: expected: 1511f6c003ace805eafeb1132727791326283cff88a923d76329e1892bba7a10
22:23:50 ERROR: got     : 2a0ea7072d1806b8526489bcd3b4847a06ab010ee32ba3c3d4e5a3235d3eb138
22:23:50 ERROR: Incomplete download, or man-in-the-middle (MITM) attack

Based on containernetworking/plugins#1038 and containernetworking/plugins#1019 (comment) this is a legitimate change.

Updated the SHAs to match the new files

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 15, 2024
@k8s-ci-robot k8s-ci-robot requested a review from prezha May 15, 2024 16:18
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 15, 2024
@spowelljr
Copy link
Member Author

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@medyagh
Copy link
Member

medyagh commented May 18, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 18, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18896) |
+----------------+----------+---------------------+
| minikube start | 49.4s    | 49.5s               |
| enable ingress | 23.8s    | 26.1s               |
+----------------+----------+---------------------+

Times for minikube start: 47.2s 50.8s 50.6s 47.6s 50.8s
Times for minikube (PR 18896) start: 48.8s 49.6s 51.6s 49.0s 48.5s

Times for minikube ingress: 23.9s 23.9s 23.4s 24.0s 23.9s
Times for minikube (PR 18896) ingress: 25.0s 26.9s 25.4s 28.0s 25.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18896) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 23.1s               |
| enable ingress | 21.9s    | 21.8s               |
+----------------+----------+---------------------+

Times for minikube start: 23.2s 24.1s 23.1s 20.2s 21.1s
Times for minikube (PR 18896) start: 24.0s 23.5s 20.3s 23.9s 23.7s

Times for minikube ingress: 21.2s 21.3s 21.8s 22.8s 22.2s
Times for minikube (PR 18896) ingress: 22.7s 21.7s 21.7s 21.7s 21.2s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 18896) |
+-------------------+----------+---------------------+
| minikube start    | 20.9s    | 20.6s               |
| ⚠️  enable ingress | 27.2s    | 34.8s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube (PR 18896) start: 20.5s 22.7s 19.6s 20.7s 19.7s
Times for minikube start: 22.6s 19.7s 20.2s 19.7s 22.4s

Times for minikube ingress: 31.2s 32.2s 20.2s 20.2s 32.2s
Times for minikube (PR 18896) ingress: 31.2s 31.2s 32.2s 32.2s 47.2s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_crio TestAddons/parallel/Registry (gopogh) 0.00 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 4.58 (chart)
Hyper-V_Windows TestDockerFlags (gopogh) 4.82 (chart)
QEMU_macOS TestFunctional/parallel/CertSync (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/CpCmd (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/DashboardCmd (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/FileSync (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/NodeLabels (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/Format (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/List (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/URL (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/SSHCmd (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/StatusCmd (gopogh) 14.71 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 14.71 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

medyagh
medyagh approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, hyperv failures seems to normal flakes

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 05b26bf into kubernetes:master May 20, 2024
27 of 41 checks passed
@spowelljr spowelljr deleted the fixCNIPluginsHash branch May 20, 2024 17:32
@medyagh medyagh mentioned this pull request May 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@ComradeProgrammer ComradeProgrammer Awaiting requested review from ComradeProgrammer

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@spowelljr @minikube-bot @medyagh @minikube-pr-bot @k8s-ci-robot