Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add luomengY as reviewer #5613

Merged
merged 1 commit into from
May 17, 2024
Merged

add luomengY as reviewer #5613

merged 1 commit into from
May 17, 2024

Conversation

luomengY
Copy link
Member

What type of PR is this?

What this PR does / why we need it:
I have made some contributions in KubeEdge, especially in edgenode management , mapper-framework and keadm, etc.
PRs: https://github.com/kubeedge/kubeedge/pulls/luomengY
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 15, 2024
Copy link
Contributor

@wbc6080 wbc6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort in alphabetical order

Signed-off-by: 2938893385@qq.com <2938893385@qq.com>
@luomengY
Copy link
Member Author

Please sort in alphabetical order

ok,Done

Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for your contributions! :)
cc @Shelley-BaoYue @WillardHu @kubeedge/maintainers

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
@WillardHu
Copy link
Collaborator

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WillardHu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@kubeedge-bot kubeedge-bot merged commit 8badcf5 into kubeedge:master May 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants