fix:imageprepulljob not report when nodename is not exist #5534
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
size/M
|
/kind bug |
cloud/pkg/taskmanager/nodeupgradecontroller/node_upgrade_controller.go
Outdated
Show resolved
Hide resolved
Piwriw
force-pushed
the
fix-imagepre-node
branch
from
b2f35d6
to
84a8c07
Compare
Piwriw
force-pushed
the
fix-imagepre-node
branch
from
84a8c07
to
de86f23
Compare
Piwriw
force-pushed
the
fix-imagepre-node
branch
from
de86f23
to
7fdeda7
Compare
|
Please modify this PR description: **Which issue(s) this PR fixes**:
Fixes #5531 |
Piwriw
force-pushed
the
fix-imagepre-node
branch
from
4481093
to
ddde848
Compare
cloud/pkg/taskmanager/imageprepullcontroller/image_prepull_controller.go
Show resolved
Hide resolved
cloud/pkg/taskmanager/nodeupgradecontroller/node_upgrade_controller.go
Outdated
Show resolved
Hide resolved
cloud/pkg/taskmanager/imageprepullcontroller/image_prepull_controller.go
Outdated
Show resolved
Hide resolved
| GetNodeStatus(string) ([]v1alpha1.TaskStatus, error) | ||
| UpdateNodeStatus(string, []v1alpha1.TaskStatus) error | ||
| StageCompleted(taskID string, state api.State) bool | ||
| GetTaskNodes(name string) ([]string, error) |
There was a problem hiding this comment.
Sorry, I'm still confused about this function GetTaskNodes. I cannot find where implement it or use it. Could you please explain more about this?
There was a problem hiding this comment.
sorry,it is my problem,I forget to delete it .I must apologize for any inconvenience it may have caused you. Thanks for your time.Now is update.
Signed-off-by: joohwan <piwriw@163.com>
| successNodes, failNodes := controller.ValidateNode(message) | ||
| nodeStatus = make([]v1alpha1.TaskStatus, 0, len(message.Name)) | ||
| for _, node := range failNodes { | ||
| nodeStatus = append(nodeStatus, v1alpha1.TaskStatus{NodeName: node.Name, State: api.TaskFailed}) |
There was a problem hiding this comment.
Please set fields Event, Action and Reason to ensure that the error is traceable.
There was a problem hiding this comment.
Sorry，it passed a week.Now is updated.
Signed-off-by: joohwan <piwriw@163.com>
| nodeStatus = append(nodeStatus, v1alpha1.TaskStatus{ | ||
| NodeName: node.Name, | ||
| State: api.TaskFailed, | ||
| Event: "Check", |
There was a problem hiding this comment.
Is the event type always "Check" here?
| if err != nil { | ||
| klog.Warningf("get node list error: %s", err.Error()) | ||
| return nil | ||
| return nil, nil | ||
| } | ||
| for _, node := range nodes { | ||
| if !util.IsEdgeNode(node) { |
There was a problem hiding this comment.
Thare are nodes status records are ignored that not edge nodes and not ready nodes. I think these nodes need to be recorded in the state as well
| nodes, err := bc.getNodeList(taskMessage.NodeNames, taskMessage.LabelSelector) | ||
| func (bc *BaseController) ValidateNode(taskMessage util.TaskMessage) ([]*v1.Node, []*v1.Node) { | ||
| var validateNodes []*v1.Node | ||
| nodes, nodesNonExist, err := bc.getNodeList(taskMessage.NodeNames, taskMessage.LabelSelector) |
There was a problem hiding this comment.
If there is an error here, the status will not have any feedback, we can only find the cloudcore log, is this what we expected?
What type of PR is this?
What this PR does / why we need it:
fix:imageprepulljob not report when nodename is not exist
Which issue(s) this PR fixes:
Fixes #5531
Special notes for your reviewer:
Does this PR introduce a user-facing change?: