fix panic when using controller-runtime: log.SetLogger(...) was never called #5503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
size/XS
Signed-off-by: Shelley-BaoYue <baoyue2@huawei.com>
Shelley-BaoYue
force-pushed
the
ctrlruntimelog
branch
from
d3d249e
to
9d12376
Compare
WillardHu
reviewed
Apr 2, 2024
| @@ -54,6 +56,7 @@ func NewAccessRoleControllerManager(ctx context.Context, kubeCfg *rest.Config) ( | |||
| } | |||
|
|
|||
| func setupControllers(ctx context.Context, mgr manager.Manager) error { | |||
| ctrlruntimelog.SetLogger(logr.New(ctrlruntimelog.NullLogSink{})) | |||
There was a problem hiding this comment.
- Would it be better to put it in New() func?
- We can use the klog instance to set the logger of the runtime-controller.
- Do other runtime-controllers also need to set logger?
func NewAccessRoleControllerManager() {
...
ctrlruntimelog.SetLogger(klog.Background())
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When enable the requireAuthorization the feature, cloudcore will break with panic:
Due to controller-runtime v0.15.0 bump and changes made in kubernetes-sigs/controller-runtime#2317, you must set a logger for controller-runtime. In our situation for cloudcore, we can set controller-runtime's logger to Null.