Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing delete button display based on permission #1197

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

saroarhossain57
Copy link

@saroarhossain57 saroarhossain57 commented Aug 8, 2023

Delete person icon is visible for the unauthorized user roles who don't have person delete permission.

If I log in as any other user role and that user role doesn't have permission to delete a person but still I can see the delete button although the delete button does not delete the user and as expected there is an error message about permission. I think it should hide the delete button if the user doesn't have permission to delete any person from the table.

Issue #1196

Screencast for the issue.

Watch Video

Steps to reproduce

  1. Add a new user with anything other user role like Editor.
  2. Remove contact delete permission for that role.
  3. Login with that newly created user.
  4. Go to the contacts page and see there is a delete button showing that you have disabled the delete permission.

@prabhat-webkul
Copy link
Collaborator

not only persons but needs to apply changes to the entire CRM.

@komal-sh-27
Copy link
Collaborator

For delete icon this PR is works fine, but needs to edit icon also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants