fix(core): remove the killed execution from the map after killing it #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchiotludo
force-pushed
the
develop
branch
13 times, most recently
from
41e0ce3
to
5b28dc1
Compare
loicmathieu
force-pushed
the
fix-kill-task-clear-map
branch
from
9d802a9
to
3aaf0b5
Compare
|
@tchiotludo I think this one should also be merged as it avoid a slight memory leak on killed execution. |
brian-mulier-p
force-pushed
the
develop
branch
from
8b19413
to
d28b63d
Compare
loicmathieu
force-pushed
the
fix-kill-task-clear-map
branch
from
3aaf0b5
to
fbc9eac
Compare
loicmathieu
force-pushed
the
fix-kill-task-clear-map
branch
2 times, most recently
from
dd129d5
to
0de98a9
Compare
loicmathieu
force-pushed
the
fix-kill-task-clear-map
branch
from
0de98a9
to
b05c66c
Compare
tchiotludo
force-pushed
the
develop
branch
3 times, most recently
from
2dc2842
to
ab62ba9
Compare
loicmathieu
force-pushed
the
fix-kill-task-clear-map
branch
from
b05c66c
to
513146e
Compare
|
tchiotludo
force-pushed
the
develop
branch
3 times, most recently
from
febd835
to
51d21c8
Compare
loicmathieu
force-pushed
the
fix-kill-task-clear-map
branch
from
513146e
to
82e9470
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be safe to purge the map at this stage.
And should fix a small memory leak when killing task often.