-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate regex before building image for e2e test #5783
Validate regex before building image for e2e test #5783
Conversation
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
@JorTurFer PTAL. |
CHANGELOG.md
Outdated
@@ -64,6 +64,7 @@ Here is an overview of all new **experimental** features: | |||
|
|||
### Improvements | |||
|
|||
- **General**: Added Pre Regex check before building image in e2e test ([#5783](https://github.com/kedacore/keda/issues/5783)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move this into Other section
/run-e2e nonsense |
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
This won't help here, because the workflow is executed from |
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just the id
is missing
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's merge this and check if it works (sadly, we cannot test the change here during the PR 🤷 )
/skip-e2e |
Added the Regex check before building image and made refactored changes accordingly.
Checklist
Fixes #4750
Relates to #